r90221 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r90220‎ \| r90221 \| r90222 >
Date:	18:49, 16 June 2011
Author:	brion
Status:	ok (Comments)
Tags:
Comment:	* (bug 29424) Fix for underscore form and other non-normalized usernames on Special:GlobalUserRights (CentralAuth version) Names weren't being validated at all before being sent off to CentralAuthUser, which itself doesn't seem to do any validation. Running through User::getCanonicalName() to clean it up, same as is used for User::newFromName().
Modified paths:	/trunk/extensions/CentralAuth/CentralAuthGroupMembershipProxy.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/CentralAuthGroupMembershipProxy.php
—	—	@@ -19,6 +19,7 @@
20	20	}
21	21
22	22	public static function newFromName( $name ) {
	23	+ $name = User::getCanonicalName( $name );
23	24	$globalUser = new CentralAuthUser( $name );
24	25	return $globalUser->exists() ? new CentralAuthGroupMembershipProxy( $globalUser ) : null;
25	26	}

Follow-up revisions

Revision	Commit summary	Author	Date
r92258	MFT r90221, r90723, r91145	reedy	17:49, 15 July 2011
r92270	MFT r91145, r90221 to 1.17wmf1 and REL1.18	reedy	18:33, 15 July 2011

Comments

#Comment by Brion VIBBER (talk | contribs) 18:51, 16 June 2011

Quick fix needs backport to 1.17 & 1.18 & for deployment.

Status & tagging log

18:34, 15 July 2011 Reedy (talk | contribs) changed the tags for r90221 [removed: 1.17wmf1,1.18]
17:49, 15 July 2011 Reedy (talk | contribs) changed the tags for r90221 [removed: 1.17]
00:54, 1 July 2011 Reedy (talk | contribs) changed the status of r90221 [removed: new added: ok]
18:51, 16 June 2011 Brion VIBBER (talk | contribs) changed the tags for r90221 [added: 1.17,1.17wmf1,1.18]