r92258 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92257‎ | r92258 | r92259 >
Date:17:49, 15 July 2011
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/REL1_17/extensions (modified) (history)
  • /branches/REL1_17/extensions/CentralAuth/CentralAuthGroupMembershipProxy.php (modified) (history)
  • /branches/REL1_17/extensions/LiquidThreads/classes/Hooks.php (modified) (history)
  • /branches/REL1_17/extensions/SimpleSurvey/SimpleSurvey.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/extensions/SimpleSurvey/SimpleSurvey.php
@@ -3,32 +3,21 @@
44 $dir = dirname( __FILE__ ) . '/';
55
66 // from prefswitch in usability initiative
7 -$prefswitchdir = dirname( dirname( __FILE__ ) ) . "/PrefSwitch";
 7+$prefswitchdir = dirname( dirname( __FILE__ ) ) . '/PrefSwitch';
88 // Horrible back for back compat with pre-r73480 installs
99 if ( !is_dir( $prefswitchdir ) ) {
10 - $prefswitchdir = dirname( dirname( __FILE__ ) ) . "/UsabilityInitiative/PrefSwitch";
 10+ $prefswitchdir = dirname( dirname( __FILE__ ) ) . '/UsabilityInitiative/PrefSwitch';
1111 }
1212
 13+require_once( $prefswitchdir . '/PrefSwitch.php' );
 14+
1315 // Use this to override the URL of ext.prefSwitch.{js,css} if needed
1416 $wgSimpleSurveyJSPath = null;
1517 $wgSimpleSurveyCSSPath = null;
1618
1719 // Adds Autoload Classes
18 -$wgAutoloadClasses = array_merge(
19 - $wgAutoloadClasses,
20 - array(
21 - 'PrefSwitchSurvey' => $prefswitchdir . '/PrefSwitch.classes.php',
22 - 'PrefSwitchSurveyField' => $prefswitchdir . '/PrefSwitch.classes.php',
23 - 'PrefSwitchSurveyFieldSelect' => $prefswitchdir . '/PrefSwitch.classes.php',
24 - 'PrefSwitchSurveyFieldRadios' => $prefswitchdir . '/PrefSwitch.classes.php',
25 - 'PrefSwitchSurveyFieldChecks' => $prefswitchdir . '/PrefSwitch.classes.php',
26 - 'PrefSwitchSurveyFieldBoolean' => $prefswitchdir . '/PrefSwitch.classes.php',
27 - 'PrefSwitchSurveyFieldDimensions' => $prefswitchdir . '/PrefSwitch.classes.php',
28 - 'PrefSwitchSurveyFieldText' => $prefswitchdir . '/PrefSwitch.classes.php',
29 - 'SimpleSurvey' => $dir . "SimpleSurvey.classes.php",
30 - 'SpecialSimpleSurvey' => $dir . 'SpecialSimpleSurvey.php',
31 - )
32 -);
 20+$wgAutoloadClasses['SimpleSurvey'] = $dir . 'SimpleSurvey.classes.php';
 21+$wgAutoloadClasses['SpecialSimpleSurvey'] = $dir . 'SpecialSimpleSurvey.php';
3322
3423 // add special pages
3524 $wgSpecialPages['SimpleSurvey'] = 'SpecialSimpleSurvey';
@@ -50,7 +39,7 @@
5140 $wgValidSurveys = array();
5241
5342 // add surveys
54 -require_once( $dir . "Surveys.php" );
 43+require_once( $dir . 'Surveys.php' );
5544
5645 // Always include the browser stuff...
5746 foreach ( $wgPrefSwitchSurveys as &$survey ) {
Index: branches/REL1_17/extensions/LiquidThreads/classes/Hooks.php
@@ -195,7 +195,7 @@
196196 $threadInfo .= "\t" . Xml::element( $key, null, $value ) . "\n";
197197 }
198198
199 - $out .= Xml::tags( 'DiscussionThreading', null, $threadInfo ) . "\n";
 199+ $out .= UtfNormal::cleanUp( Xml::tags( 'DiscussionThreading', null, $threadInfo ) . "\n" );
200200
201201 return true;
202202 }
Index: branches/REL1_17/extensions/CentralAuth/CentralAuthGroupMembershipProxy.php
@@ -19,6 +19,7 @@
2020 }
2121
2222 public static function newFromName( $name ) {
 23+ $name = User::getCanonicalName( $name );
2324 $globalUser = new CentralAuthUser( $name );
2425 return $globalUser->exists() ? new CentralAuthGroupMembershipProxy( $globalUser ) : null;
2526 }
Property changes on: branches/REL1_17/extensions
___________________________________________________________________
Modified: svn:mergeinfo
2627 Merged /trunk/extensions:r90221,90723,91145

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90221* (bug 29424) Fix for underscore form and other non-normalized usernames on S...brion18:49, 16 June 2011
r90723* (bug 29564) Fix XML export output when LiquidThreads thread data contains b...brion18:12, 24 June 2011
r91145bug 29650 - [SimpleSurvey] PrefStats not properly loaded (<prefswitch-surv...krinkle23:46, 29 June 2011

Status & tagging log