r90722 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90721‎ | r90722 | r90723 >
Date:17:32, 24 June 2011
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
Release-note fixes

Summaries in release notes must describe either what has been done or what should be done, not (just) what "happens" or "happened". ie. "Setting $foo to true triggers Bar" is not very useful. "Do Lorem if $foo is true" or "Lorem is now done when $foo is true" is more useful.

(Also follows up on r88356 CR)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -46,16 +46,16 @@
4747 Also built-in support for distribution through a TestSwarm instance.
4848 * (bug 29036) For cascade-protected pages, the mw-textarea-cprotected class is
4949 added to the textarea on the edit form.
50 -* mw.util.getScript has been implemented (like wfScript in GlobalFunctions.php)
51 -* (bug 29067) Creating "user.tokens" module (like user.options) in ResourceLoader.
 50+* mw.util.wikiScript has been implemented (like wfScript in GlobalFunctions.php)
 51+* (bug 29067) Expose user.tokens (like we do user.options) in ResourceLoader.
5252 * New 'Debug' hook used by wfDebug() and wfDebugLog()
5353 * (bug 27655) Require token for watching/unwatching pages)
5454 * (bug 28904) Update jQuery version from 1.4.4 to 1.6.1 (the latest version)
5555 * (bug 29441) Expose CapitalLinks config in JS to allow modules to properly
5656 handle titles on case-sensitive wikis.
5757 * (bug 29397) Implement mw.Title module in core.
58 -* In MySQL 4.1.9+ with replication enabled, get the slave lag from SHOW SLAVE
59 - STATUS instead of SHOW PROCESSLIST.
 58+* In MySQL 4.1.9+ with replication enabled, the slave lag should come from
 59+ SHOW SLAVE STATUS instead of SHOW PROCESSLIST.
6060 * Language codes in $wgDummyLanguageCodes are now excluded on localization
6161 statistics (maintenance/language/transstat.php)
6262
@@ -71,7 +71,7 @@
7272 * (bug 23002) Imagelinks table not updated after imagemove.
7373 * (bug 27864) Transcluding {{Special:Prefix}} with empty prefix now lists all
7474 pages.
75 -* (bug 18803) JPEG2000 images can no longer be uploaded as JPEG image.
 75+* (bug 18803) JPEG2000 images should not be uploadable as .jpg files.
7676 * (bug 11868) If using links to count articles, the checking will now be based
7777 on the real presence of an internal link instead of the "[[" string
7878 * (bug 28287) The "your changes" box for edit conflicts is now read-only.
@@ -84,25 +84,25 @@
8585 LTR/RTL screen layout.
8686 * (bug 28992) Revision numbers in the patrol log are transformed in the user
8787 language.
88 -* (bug 27073) ResourceLoaderDynamicStyles should be dynamically appended to
89 - the document if it doesn't exist.
90 -* (bug 27023) After dom ready event, using mediawiki.loader.using will
91 - call callback too early.
92 -* (bug 4330) External URLs without custom title should be treated as LTR,
93 - also in RTL text.
94 -* (bug 29055) Make don't send email on minor edits preference apply to
 88+* (bug 27073) ResourceLoaderDynamicStyles marker should be dynamically appended to
 89+ the document head if it doesn't exist.
 90+* (bug 27023) After the document is ready, mw.loader is broken (calls callback
 91+ before module is parsed).
 92+* (bug 4330) External URLs without a custom title should be treated as LTR,
 93+ even in RTL text.
 94+* (bug 29055) Make "don't send email on minor edits" preference apply to
9595 changes to talk page in addition to watchlist edits.
9696 * (bug 29071) mediawiki.action.watch.ajax.js should pass uselang to API.
97 -* (bug 28272) Special:Allmessages should have only one "Go" button
98 -* (bug 29101) Special:FileDuplicateSearch no longer shows silly message
 97+* (bug 28272) Special:AllMessages should have only one "Go" button.
 98+* (bug 29101) Special:FileDuplicateSearch no longer shows silly message.
9999 * (bug 29048) jQuery.tabIndex: firstTabIndex() should not output the same
100100 as lastTabIndex().
101101 * (bug 29332) Warn if user requests mediawiki-announce subscription but does not
102102 enter an e-mail address.
103 -* (bug 25375) Add canonical namespaces to JavaScript "wgNamespaceIds"
 103+* (bug 25375) Add canonical namespaces to "wgNamespaceIds" in mw.config.
104104 * The class JpegOrTiffHandler was renamed ExifBitmapHandler.
105105 * (bug 29443) Special:Undelete should use JavaScript to invert all checkboxes
106 - without reloading the page
 106+ instead of reloading the page.
107107 * (bug 29325) Setting $wgStrictFileExtensions to false no longer gives incorrect warning
108108 * (bug 29437) Multiple apostrophes in deleted article title cause odd rendering
109109 * (bug 29485) RSS feed of Special:RecentChange grouped together multiple
@@ -122,19 +122,19 @@
123123
124124 === API changes in 1.19 ===
125125 * BREAKING CHANGE: action=watch now requires POST and token.
126 -* (bug 27790) Add query type for querymodules to action=paraminfo
127 -* (bug 28963) Add langbacklinks module to api
128 -* (bug 27593) API: add error message when sha1/sha1base36 is invalid
 126+* (bug 27790) Add query type for querymodules to output of ApiParamInfo
 127+* (bug 28963) Add langbacklinks query module to the api
 128+* (bug 27593) API should return error message when sha1/sha1base36 is invalid
129129 * (bug 28578) API's parse module should not silently override invalid
130130 title inputs
131 -* (bug 20699) API watchlist should list log-events
132 -* (bug 29070) Add token to action=watch API
133 -* (bug 29221) Expose oldrevid in watchlist output
 131+* (bug 20699) Watchlist API should list log-events
 132+* (bug 29070) Require a token in API action=watch
 133+* (bug 29221) Expose oldrevid in ApiQueryWatchlist output
134134 * (bug 29267) Always give the servername for meta=siteinfo&siprop=dbrepllag
135135 * (bug 28897) rvparse now respects rvsection for action=query&prop=revisions
136 -* (bug 25734) API: possible issue with revids validation
 136+* (bug 25734) API: Possible issue with revids validation
137137 * (bug 28002) Internal error in ApiFormatRaw::getMimeType
138 -* (bug 29237) Add interwiki target url attribute to api/query/interwiki
 138+* (bug 29237) ApiQuery now has an option to output the "iwurl" attribute.
139139 * (bug 28392) Mark action=undelete&timestamps as type "timestamp"
140140 * (bug 21346) Make deleted images searchable by hash (disabled in Miser Mode)
141141 * (bug 27595) sha1 search of list=filearchive does not work
@@ -155,7 +155,7 @@
156156 === Other changes in 1.19 ===
157157 * Removed legacy wgAjaxWatch javascript global object, no longer in use.
158158 * (bug 28556) Upload support for MacBinary files has been removed (Used by
159 - Internet Explorer 5 for MacOS 9)
 159+ Internet Explorer 5 for Mac OS 9)
160160
161161 == Compatibility ==
162162

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88356Adding release notes for recent bug fixes and functionality added by me durin...krinkle22:14, 17 May 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   19:29, 24 June 2011

"After the document is ready, mw.loader is broken..." is still not worded well. It makes it sound like you *broke* it now :)

Status & tagging log