r89553 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r89552‎ | r89553 | r89554 >
Date:09:41, 6 June 2011
Author:catrope
Status:ok
Tags:
Comment:
Fix the non-PEAR alternative for Services_JSON_Error to be less useless. bug 29278 shows an error related to this class not being stringifiable
Modified paths:
  • /trunk/phase3/includes/json/Services_JSON.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/json/Services_JSON.php
——@@ -870,7 +870,12 @@
871871 function Services_JSON_Error($message = 'unknown error', $code = null,
872872 $mode = null, $options = null, $userinfo = null)
873873 {
874 -
 874+ $this->message = $message;
875875 }
 876+
 877+ function __toString()
 878+ {
 879+ return $this->message;
 880+ }
876881 }
877882 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r895551.17wmf1: MFT r89553catrope09:45, 6 June 2011
r90270Related to bug 29278, and from the comments in bug 14210, mention the edit to...reedy14:55, 17 June 2011
r90490* (bug 29278) server error 500 when attempting to add text to a page via redi...reedy22:32, 20 June 2011
r90492* (bug 29278) server error 500 when attempting to add text to a page via redi...reedy22:39, 20 June 2011
r92339REL1_18 MFT r89401, r89451, r89512, r89513, r89523, r89529, r89532, r89549, r...reedy23:08, 15 July 2011
r92434MFT to REL1_18...hashar15:05, 18 July 2011

Status & tagging log