r89523 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r89522‎ | r89523 | r89524 >
Date:19:22, 5 June 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
* (bug 28002) Internal error in ApiFormatRaw::getMimeType

If we just return when no titles, we don't format anything, and everything breaks

Might aswell just unconditionally export, as even with no titles, we still get all the siteinfo and such
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/api/ApiQuery.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
——@@ -98,6 +98,7 @@
9999 * (bug 29267) always give the servername for meta=siteinfo&siprop=dbrepllag
100100 * (bug 28897) rvparse doesn’t seem to work with rvsection
101101 * (bug 25734) API: possible issue with revids validation
 102+* (bug 28002) Internal error in ApiFormatRaw::getMimeType
102103
103104 === Languages updated in 1.19 ===
104105
Index: trunk/phase3/includes/api/ApiQuery.php
——@@ -484,10 +484,6 @@
485485 }
486486 }
487487 }
488 - // only export when there are titles
489 - if ( !count( $exportTitles ) ) {
490 - return;
491 - }
492488
493489 $exporter = new WikiExporter( $this->getDB() );
494490 // WikiExporter writes to stdout, so catch its

Follow-up revisions

RevisionCommit summaryAuthorDate
r91479Merge r89523reedy19:43, 5 July 2011
r92339REL1_18 MFT r89401, r89451, r89512, r89513, r89523, r89529, r89532, r89549, r...reedy23:08, 15 July 2011

Comments

#Comment by Reedy (talk | contribs)   19:36, 5 July 2011

Tagging for 1.17wmf1 and 1.18

Should be put in 1.17wmf1 to fix the apache logs on the WMF cluster

Status & tagging log