r90492 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90491‎ | r90492 | r90493 >
Date:22:39, 20 June 2011
Author:reedy
Status:ok
Tags:
Comment:
* (bug 29278) server error 500 when attempting to add text to a page via redirect (redirect points to the page and page is edited)

Merge r90490, r89553
Modified paths:
  • /branches/REL1_17/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_17/phase3/includes/api/ApiEditPage.php (modified) (history)
  • /branches/REL1_17/phase3/includes/json (modified) (history)
  • /branches/REL1_17/phase3/includes/json/Services_JSON.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/json/Services_JSON.php
@@ -870,7 +870,12 @@
871871 function Services_JSON_Error($message = 'unknown error', $code = null,
872872 $mode = null, $options = null, $userinfo = null)
873873 {
874 -
 874+ $this->message = $message;
875875 }
 876+
 877+ function __toString()
 878+ {
 879+ return $this->message;
 880+ }
876881 }
877882 }
Property changes on: branches/REL1_17/phase3/includes/json/Services_JSON.php
___________________________________________________________________
Modified: svn:mergeinfo
878883 Merged /trunk/phase3/includes/json/Services_JSON.php:r89553
Property changes on: branches/REL1_17/phase3/includes/json
___________________________________________________________________
Added: svn:mergeinfo
879884 Merged /branches/sqlite/includes/json:r58211-58321
880885 Merged /trunk/phase3/includes/json:r82474,82845,82847-82848,85752,89553
881886 Merged /branches/new-installer/phase3/includes/json:r43664-66004
882887 Merged /branches/wmf-deployment/includes/json:r53381
883888 Merged /branches/REL1_15/phase3/includes/json:r51646
Index: branches/REL1_17/phase3/includes/api/ApiEditPage.php
@@ -63,11 +63,7 @@
6464 $oldTitle = $titleObj;
6565
6666 $titles = Title::newFromRedirectArray( Revision::newFromTitle( $oldTitle )->getText( Revision::FOR_THIS_USER ) );
67 - //array_shift( $titles );
68 -
69 - $this->getResult()->addValue( null, 'foo', $titles );
70 -
71 -
 67+
7268 $redirValues = array();
7369 foreach ( $titles as $id => $newTitle ) {
7470
Index: branches/REL1_17/phase3/RELEASE-NOTES
@@ -47,6 +47,8 @@
4848 * (bug 29233) Fixed failover for DB slave servers. When a DB slave went down,
4949 an error was immediately shown to the user, instead of trying another slave.
5050 Was broken since 1.17 beta 1.
 51+* (bug 29278) server error 500 when attempting to add text to a page via redirect
 52+ (redirect points to the page and page is edited)
5153
5254 === Changes since 1.17 beta 1 ===
5355
@@ -62,7 +64,7 @@
6365 * When installing on PostgreSQL and the install account is the same as the web
6466 account, check to make sure that the account has suitable privileges in the
6567 mediawiki schema.
66 -* (Bug 28172) Fixed error in PostgreSQL installation when creating the wiki
 68+* (bug 28172) Fixed error in PostgreSQL installation when creating the wiki
6769 sysop account.
6870 * Fixed an issue with the Oracle installer in cases where the user is different
6971 to the database name.

Follow-up revisions

RevisionCommit summaryAuthorDate
r90569Updates for 1.17.0, release notes fixes for r90341 and r90492.tstarling03:56, 22 June 2011
r92434MFT to REL1_18...hashar15:05, 18 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89553Fix the non-PEAR alternative for Services_JSON_Error to be less useless. bug ...catrope09:41, 6 June 2011
r90270Related to bug 29278, and from the comments in bug 14210, mention the edit to...reedy14:55, 17 June 2011
r90490* (bug 29278) server error 500 when attempting to add text to a page via redi...reedy22:32, 20 June 2011

Status & tagging log