r89532 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89531‎ | r89532 | r89533 >
Date:21:03, 5 June 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Followup r89529

Fix non static caller of getExistingLocalSettings
Modified paths:
  • /trunk/phase3/includes/installer/CliInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/CliInstaller.php
@@ -88,7 +88,7 @@
8989 * Main entry point.
9090 */
9191 public function execute() {
92 - $vars = $this->getExistingLocalSettings();
 92+ $vars = Installer::getExistingLocalSettings();
9393 if( $vars ) {
9494 $this->showStatusMessage(
9595 Status::newFatal( "config-localsettings-cli-upgrade" )

Follow-up revisions

RevisionCommit summaryAuthorDate
r896771.17: MFT r88492, r88870, r88871, r89003, r89108, r89114, r89115, r89129, r89...catrope19:14, 7 June 2011
r89679MFT r89529, r89532demon19:24, 7 June 2011
r92339REL1_18 MFT r89401, r89451, r89512, r89513, r89523, r89529, r89532, r89549, r...reedy23:08, 15 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89529Follow-up r89254 and r89481: re-did loading extension updates properly, now u...maxsem19:52, 5 June 2011

Comments

#Comment by MaxSem (talk | contribs)   01:30, 6 June 2011

Thanks, Sam.

Status & tagging log