r90490 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r90489‎ | r90490 | r90491 >
Date:22:32, 20 June 2011
Author:reedy
Status:ok
Tags:
Comment:
* (bug 29278) server error 500 when attempting to add text to a page via redirect (redirect points to the page and page is edited)

Needs 1.17 and 1.18 backporting, so release notes will go in 1.17
Modified paths:
  • /trunk/phase3/includes/api/ApiEditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiEditPage.php
——@@ -67,8 +67,6 @@
6868 $titles = Title::newFromRedirectArray( Revision::newFromTitle( $oldTitle )->getText( Revision::FOR_THIS_USER ) );
6969 // array_shift( $titles );
7070
71 - $apiResult->addValue( null, 'foo', $titles );
72 -
7371 $redirValues = array();
7472 foreach ( $titles as $id => $newTitle ) {
7573

Follow-up revisions

RevisionCommit summaryAuthorDate
r90492* (bug 29278) server error 500 when attempting to add text to a page via redi...reedy22:39, 20 June 2011
r90493MFT manually r90490reedy22:39, 20 June 2011
r92434MFT to REL1_18...hashar15:05, 18 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75280Revert r70703 and followup r70715: broke &redirect for API edit with a fatal ...catrope17:48, 23 October 2010
r89553Fix the non-PEAR alternative for Services_JSON_Error to be less useless. bug ...catrope09:41, 6 June 2011
r90270Related to bug 29278, and from the comments in bug 14210, mention the edit to...reedy14:55, 17 June 2011

Status & tagging log