r86183 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86182‎ | r86183 | r86184 >
Date:07:46, 16 April 2011
Author:ialex
Status:ok (Comments)
Tags:
Comment:
* (bug 28568) Entries in the iwlinks table are now removed on page deletion
Modified paths:
  • /trunk/phase3/HISTORY (modified) (history)
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/HISTORY
@@ -457,6 +457,7 @@
458458 * (bug 1379) Installer directory conflicts with some hosts' configuration panel.
459459 * (bug 12070) After Installation MySQL was blocked
460460 * Fix XML well-formedness on a few pages when $wgHtml5 is true (the default)
 461+* (bug 28568) Entries in the iwlinks table are now removed on page deletion
461462
462463 === API changes in 1.17 ===
463464 * (bug 22738) Allow filtering by action type on query=logevent.
Index: trunk/phase3/includes/Article.php
@@ -3134,6 +3134,7 @@
31353135 $dbw->delete( 'templatelinks', array( 'tl_from' => $id ) );
31363136 $dbw->delete( 'externallinks', array( 'el_from' => $id ) );
31373137 $dbw->delete( 'langlinks', array( 'll_from' => $id ) );
 3138+ $dbw->delete( 'iwlinks', array( 'iwl_from' => $id ) );
31383139 $dbw->delete( 'redirect', array( 'rd_from' => $id ) );
31393140 }
31403141

Follow-up revisions

RevisionCommit summaryAuthorDate
r86184* (bug 28568) Entries in the iwlinks table are now removed on page deletion...ialex07:51, 16 April 2011
r864641.17wmf1: MFT r85377, r85555, r85583, r86100, r86121, r86130, r86142, r86146,...catrope11:27, 20 April 2011
r91777Followup r86183 and per bug 28628...reedy03:43, 9 July 2011

Comments

#Comment by Bryan (talk | contribs)   08:13, 18 April 2011

Ideally there would be a (static) method in LinksUpdate, so that modification of all links table is done in the same class.

#Comment by Duplicatebug (talk | contribs)   20:10, 20 April 2011

Move for non-cascadingDeletes database looks also broken (Title::moveToInternal)

Status & tagging log