r85555 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85554‎ | r85555 | r85556 >
Date:18:23, 6 April 2011
Author:brion
Status:ok (Comments)
Tags:
Comment:
* (bug 28306) Fix exposure of suppressed usernames in ForeignDBRepo

Patch by Umherirrender: https://bugzilla.wikimedia.org/attachment.cgi?id=8360&action=diff
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/ImagePage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImagePage.php
@@ -1079,16 +1079,16 @@
10801080
10811081 // Uploading user
10821082 $row .= '<td>';
1083 - if ( $local ) {
1084 - // Hide deleted usernames
1085 - if ( $file->isDeleted( File::DELETED_USER ) ) {
1086 - $row .= '<span class="history-deleted">' . wfMsgHtml( 'rev-deleted-user' ) . '</span>';
 1083+ // Hide deleted usernames
 1084+ if ( $file->isDeleted( File::DELETED_USER ) ) {
 1085+ $row .= '<span class="history-deleted">' . wfMsgHtml( 'rev-deleted-user' ) . '</span>';
 1086+ } else {
 1087+ if ( $local ) {
 1088+ $row .= $this->skin->userLink( $user, $usertext ) . ' <span style="white-space: nowrap;">' .
 1089+ $this->skin->userToolLinks( $user, $usertext ) . '</span>';
10871090 } else {
1088 - $row .= $this->skin->userLink( $user, $usertext ) . ' <span style="white-space: nowrap;">' .
1089 - $this->skin->userToolLinks( $user, $usertext ) . '</span>';
 1091+ $row .= htmlspecialchars( $usertext );
10901092 }
1091 - } else {
1092 - $row .= htmlspecialchars( $usertext );
10931093 }
10941094 $row .= '</td><td>';
10951095
Index: trunk/phase3/RELEASE-NOTES
@@ -229,6 +229,7 @@
230230 * (bug 28394) Set forgotten parameters types in ApiUnblock
231231 * (bug 28395) Set forgotten parameters types in ApiParse
232232 * (bug 28430) Make html and TeX output of <math> always be left-to-right.
 233+* (bug 28306) Fix exposure of suppressed usernames in ForeignDBRepo
233234
234235 === API changes in 1.18 ===
235236 * (bug 26339) Throw warning when truncating an overlarge API result

Follow-up revisions

RevisionCommit summaryAuthorDate
r864641.17wmf1: MFT r85377, r85555, r85583, r86100, r86121, r86130, r86142, r86146,...catrope11:27, 20 April 2011
r864741.17: MFT r81731, r85377, r85547, r85555, r85583, r85803, r85881, r86100, r86...catrope13:22, 20 April 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   18:24, 6 April 2011

This should be merged to 1.17 and live deployment; affects files on Commons that have had some info suppressed, the usernames are exposed when the page is viewed on other Wikimedia wikis. (Offsite wikis using InstantCommons are not affected, as the info isn't exposed through the API.)

#Comment by Catrope (talk | contribs)   18:26, 6 April 2011

For live deployment, use the 1.17wmf1 tag (added)

Status & tagging log