r86182 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86181‎ | r86182 | r86183 >
Date:07:39, 16 April 2011
Author:maxsem
Status:ok
Tags:
Comment:
Prevent bug 17790 from reappearing on Special:Preferences
Modified paths:
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
@@ -626,7 +626,9 @@
627627 $personal_urls['logout'] = array(
628628 'text' => wfMsg( 'userlogout' ),
629629 'href' => self::makeSpecialUrl( 'Userlogout',
630 - $title->isSpecial( 'Preferences' ) ? '' : $returnto
 630+ // userlogout link must always contain an & character, otherwise we might not be able
 631+ // to detect a buggy precaching proxy (bug 17790)
 632+ $title->isSpecial( 'Preferences' ) ? 'noreturnto' : $returnto
631633 ),
632634 'active' => false
633635 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r864741.17: MFT r81731, r85377, r85547, r85555, r85583, r85803, r85881, r86100, r86...catrope13:22, 20 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62967(bug 17790) Users instantly logged off on HughesNetmaxsem17:44, 25 February 2010
r62973Backported r62967 and r62968 to 1.16: (bug 17790) Users instantly logged off ...maxsem20:29, 25 February 2010

Status & tagging log