r85583 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85582‎ | r85583 | r85584 >
Date:21:58, 6 April 2011
Author:brion
Status:ok (Comments)
Tags:
Comment:
* (bug 28444) Fix regression: edit-on-doubleclick retains revision id again

Regression in 61071 caused by dropping $title->getLocalUrl($skin->getEditUrlOptions())
for the less informational $title->getEditUrl(), thus losing oldid view information.
Switching back nicely resolves it.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -2367,7 +2367,9 @@
23682368 $this->getUser()->getOption( 'editondblclick' )
23692369 )
23702370 {
2371 - $bodyAttrs['ondblclick'] = "document.location = '" . Xml::escapeJsString( $this->getTitle()->getEditURL() ) . "'";
 2371+ $editUrl = $this->getTitle()->getLocalUrl( $sk->editUrlOptions() );
 2372+ $bodyAttrs['ondblclick'] = "document.location = '" .
 2373+ Xml::escapeJsString( $editUrl ) . "'";
23722374 }
23732375
23742376 # Class bloat
Index: trunk/phase3/RELEASE-NOTES
@@ -232,6 +232,7 @@
233233 * (bug 28306) Fix exposure of suppressed usernames in ForeignDBRepo
234234 * (bug 28372) Fix bogus link to suppressed file versions in ForeignDBRepo
235235 * (bug 27473) Fix regression: bold, italic no longer interfere with linktrail for ca, kaa
 236+* (bug 28444) Fix regression: edit-on-doubleclick retains revision id again
236237
237238 === API changes in 1.18 ===
238239 * (bug 26339) Throw warning when truncating an overlarge API result

Follow-up revisions

RevisionCommit summaryAuthorDate
r864641.17wmf1: MFT r85377, r85555, r85583, r86100, r86121, r86130, r86142, r86146,...catrope11:27, 20 April 2011
r864741.17: MFT r81731, r85377, r85547, r85555, r85583, r85803, r85881, r86100, r86...catrope13:22, 20 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61071Merge all skins' output of opening <body> tag...simetrical01:16, 15 January 2010

Comments

#Comment by Brion VIBBER (talk | contribs)   22:00, 6 April 2011

Regression in 1.17, needs merge for production. Low-impact, but annoying bug. :)

Status & tagging log