r86142 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86141‎ | r86142 | r86143 >
Date:21:53, 15 April 2011
Author:bawolff
Status:ok
Tags:
Comment:
(follow-up r86121) Use strict comparision.

Third times the charm...
Modified paths:
  • /trunk/phase3/includes/CategoryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/CategoryPage.php
@@ -365,10 +365,10 @@
366366 $count = 0;
367367 foreach ( $res as $row ) {
368368 $title = Title::newFromRow( $row );
369 - if ( !$row->cl_collation ) {
 369+ if ( $row->cl_collation === '' ) {
370370 // Hack to make sure that while updating from 1.16 schema
371371 // and db is inconsistent, that the sky doesn't fall.
372 - // See r83544. Could perhaps be removed in a couple versions (?)
 372+ // See r83544. Could perhaps be removed in a couple decades...
373373 $humanSortkey = $row->cl_sortkey;
374374 } else {
375375 $humanSortkey = $title->getCategorySortkey( $row->cl_sortkey_prefix );

Sign-offs

UserFlagDate
Simetricalinspected22:36, 15 April 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r864641.17wmf1: MFT r85377, r85555, r85583, r86100, r86121, r86130, r86142, r86146,...catrope11:27, 20 April 2011
r864741.17: MFT r81731, r85377, r85547, r85555, r85583, r85803, r85881, r86100, r86...catrope13:22, 20 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86121(follow-up r86100) Make categorypage not die as much while transitioning betw...bawolff17:23, 15 April 2011

Status & tagging log