r83497 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r83496‎ | r83497 | r83498 >
Date:02:04, 8 March 2011
Author:tparscal
Status:ok
Tags:
Comment:
* Colorized the buttons on the form and calls to action
* Changed "feedback" to "ratings" on the submit button
* Added body text to calls to action
* Changed the style of calls to action to use a white background for the pitch, increasing contrast and thus visibility
Modified paths:
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.hooks.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/check.png (deleted) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/pop.png (deleted) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/success.png (added) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.css (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/ArticleFeedback.hooks.php
——@@ -31,11 +31,14 @@
3232 'articlefeedback-pitch-or',
3333 'articlefeedback-pitch-thanks',
3434 'articlefeedback-pitch-survey-message',
 35+ 'articlefeedback-pitch-survey-body',
3536 'articlefeedback-pitch-survey-accept',
3637 'articlefeedback-pitch-join-message',
 38+ 'articlefeedback-pitch-join-body',
3739 'articlefeedback-pitch-join-accept',
3840 'articlefeedback-pitch-join-login',
3941 'articlefeedback-pitch-edit-message',
 42+ 'articlefeedback-pitch-edit-body',
4043 'articlefeedback-pitch-edit-accept',
4144 'articlefeedback-survey-title',
4245 'articlefeedback-survey-message-success',
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
——@@ -57,6 +57,7 @@
5858 <div class="articleFeedback-title"></div>\
5959 <div class="articleFeedback-pop">\
6060 <div class="articleFeedback-message"></div>\
 61+ <div class="articleFeedback-body"></div>\
6162 <button class="articleFeedback-accept"></button>\
6263 <button class="articleFeedback-reject"></button>\
6364 </div>\
——@@ -307,6 +308,9 @@
308309 .find( '.articleFeedback-message' )
309310 .text( mw.msg( context.options.pitches[key].message ) )
310311 .end()
 312+ .find( '.articleFeedback-body' )
 313+ .text( mw.msg( context.options.pitches[key].body ) )
 314+ .end()
311315 .find( '.articleFeedback-accept' )
312316 .text( mw.msg( context.options.pitches[key].accept ) )
313317 .click( function() {
——@@ -317,6 +321,7 @@
318322 );
319323 } )
320324 .button()
 325+ .addClass( 'ui-button-green' )
321326 .end()
322327 .find( '.articleFeedback-reject' )
323328 .text( mw.msg( context.options.pitches[key].reject ) )
——@@ -356,7 +361,8 @@
357362 context.options.pitches[$pitch.attr( 'rel' )].altAction
358363 );
359364 } )
360 - .button();
 365+ .button()
 366+ .addClass( 'ui-button-green' );
361367 }
362368 }
363369 } )
——@@ -365,7 +371,7 @@
366372 // Activate tooltips
367373 .find( '[title]' )
368374 .tipsy( {
369 - 'gravity': 'sw',
 375+ 'gravity': 'se',
370376 'center': false,
371377 'fade': true,
372378 'delayIn': 300,
——@@ -399,6 +405,7 @@
400406 // Buttonify the button
401407 .find( '.articleFeedback-submit' )
402408 .button()
 409+ .addClass( 'ui-button-blue' )
403410 .click( function() {
404411 $.articleFeedback.fn.submit.call( context );
405412 var pitches = [];
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/pop.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/check.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/success.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/success.png
___________________________________________________________________
Added: svn:mime-type
406413 + application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.css
——@@ -90,7 +90,7 @@
9191 font-size: 1em;
9292 padding-left: 28px;
9393 line-height: 32px;
94 - background-image: url(images/check.png);
 94+ background-image: url(images/success.png);
9595 background-repeat: no-repeat;
9696 background-position: left center;
9797 margin-bottom: 0.5em;
——@@ -99,21 +99,28 @@
100100 .articleFeedback-pitch .articleFeedback-pop {
101101 padding: 1em;
102102 margin: 0;
103 - background-color: #b2d6f6;
 103+ background-color: white;
 104+ border: solid 1px silver;
 105+ /*
104106 background-image: url(images/pop.png);
105107 background-position: center center;
106108 background-repeat: no-repeat;
107 - text-align: center;
 109+ */
108110 -webkit-border-radius: 5px;
109111 -moz-border-radius: 5px;
110112 border-radius: 5px;
111113 }
112114
113115 .articleFeedback-message {
114 - margin: 0.5em;
 116+ margin: 0.33em;
115117 font-size: 1.5em;
116118 }
117119
 120+.articleFeedback-body {
 121+ margin: 0.5em;
 122+ color: #333333;
 123+}
 124+
118125 .articleFeedback-switch {
119126 cursor: pointer;
120127 color: #0645AD;
——@@ -312,7 +319,7 @@
313320 }
314321 .articleFeedback-success span {
315322 display: none;
316 - background-image: url(images/check.png);
 323+ background-image: url(images/success.png);
317324 background-repeat: no-repeat;
318325 background-position: center left;
319326 padding-left: 28px;
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js
——@@ -205,6 +205,7 @@
206206 },
207207 'title': 'articlefeedback-pitch-thanks',
208208 'message': 'articlefeedback-pitch-survey-message',
 209+ 'body': 'articlefeedback-pitch-survey-body',
209210 'accept': 'articlefeedback-pitch-survey-accept',
210211 'reject': 'articlefeedback-pitch-reject'
211212 },
——@@ -228,6 +229,7 @@
229230 },
230231 'title': 'articlefeedback-pitch-thanks',
231232 'message': 'articlefeedback-pitch-join-message',
 233+ 'body': 'articlefeedback-pitch-join-body',
232234 'accept': 'articlefeedback-pitch-join-accept',
233235 'reject': 'articlefeedback-pitch-reject',
234236 // Special alternative action for going to login page
——@@ -276,6 +278,7 @@
277279 },
278280 'title': 'articlefeedback-pitch-thanks',
279281 'message': 'articlefeedback-pitch-edit-message',
 282+ 'body': 'articlefeedback-pitch-join-body',
280283 'accept': 'articlefeedback-pitch-edit-accept',
281284 'reject': 'articlefeedback-pitch-reject'
282285 }
Index: trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php
——@@ -35,7 +35,7 @@
3636 'articlefeedback-form-panel-expertise-profession' => 'It is part of my profession',
3737 'articlefeedback-form-panel-expertise-hobby' => 'It is related to my hobbies or interests',
3838 'articlefeedback-form-panel-expertise-other' => 'The source of my knowledge is not listed here',
39 - 'articlefeedback-form-panel-submit' => 'Submit feedback',
 39+ 'articlefeedback-form-panel-submit' => 'Submit ratings',
4040 'articlefeedback-form-panel-success' => 'Saved successfully',
4141 'articlefeedback-report-switch-label' => 'View page ratings',
4242 'articlefeedback-report-panel-title' => 'Page ratings',
——@@ -54,11 +54,14 @@
5555 'articlefeedback-pitch-or' => 'or',
5656 'articlefeedback-pitch-thanks' => 'Thanks! Your ratings have been saved.',
5757 'articlefeedback-pitch-survey-message' => 'Please take a moment to complete a short survey.',
 58+ 'articlefeedback-pitch-survey-body' => '',
5859 'articlefeedback-pitch-survey-accept' => 'Start survey',
59 - 'articlefeedback-pitch-join-message' => 'Did you know that you can create an account? An account will help you track your edits, get involved in discussions, and be a part of the community.',
 60+ 'articlefeedback-pitch-join-message' => 'Did you know that you can create an account?',
 61+ 'articlefeedback-pitch-join-body' => 'An account will help you track your edits, get involved in discussions, and be a part of the community.',
6062 'articlefeedback-pitch-join-accept' => 'Create an account',
6163 'articlefeedback-pitch-join-login' => 'Log in',
6264 'articlefeedback-pitch-edit-message' => 'Did you know that you can edit this page?',
 65+ 'articlefeedback-pitch-edit-body' => '',
6366 'articlefeedback-pitch-edit-accept' => 'Edit this page',
6467 'articlefeedback-survey-message-success' => 'Thanks for filling out the survey.',
6568 'articlefeedback-survey-message-error' => 'An error has occurred.

Follow-up revisions

RevisionCommit summaryAuthorDate
r83539Follow-up r83497 for Translatewikiraymond19:08, 8 March 2011

Status & tagging log