r83061 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83060‎ | r83061 | r83062 >
Date:01:35, 2 March 2011
Author:simetrical
Status:ok (Comments)
Tags:
Comment:
Disable $wgExperimentalHtmlIds again by default

See bug 27733, bug 27694, bug 27474. Reverts r70526. Should be
backported to 1.17 (along with removing r70526's RELEASE-NOTES). Can be
ported to WMF as well, but it's kind of trivial to replicate in
LocalSettings.php, so doesn't really have to be.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
@@ -2320,11 +2320,11 @@
23212321 * not, use only HTML 4-compatible IDs. This option is for testing -- when the
23222322 * functionality is ready, it will be on by default with no option.
23232323 *
2324 - * Currently this appears to work fine in Chrome 4 and 5, Firefox 3.5 and 3.6, IE6
2325 - * and 8, and Opera 10.50, but it fails in Opera 10.10: Unicode IDs don't seem
2326 - * to work as anchors. So not quite ready for general use yet.
 2324+ * Currently this appears to work fine in all browsers, but it's disabled by
 2325+ * default because it normalizes id's a bit too aggressively, breaking preexisting
 2326+ * content (particularly Cite). See bug 27733, bug 27694, bug 27474.
23272327 */
2328 -$wgExperimentalHtmlIds = true;
 2328+$wgExperimentalHtmlIds = false;
23292329
23302330 /**
23312331 * Abstract list of footer icons for skins in place of old copyrightico and poweredbyico code

Sign-offs

UserFlagDate
Hasharinspected09:30, 2 March 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r83720Backport r83061 "Disable $wgExperimentalHtmlIds again by default"...simetrical21:00, 11 March 2011
r839321.17wmf1: MFT r78990, r79844, r81548, r82022, r82193, r83061, r83067, r83583,...catrope17:59, 14 March 2011
r85481Revert r68358. Causes bug 27474....platonides22:38, 5 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70526Enable $wgExperimentalHtmlIds by default...simetrical20:30, 5 August 2010

Comments

#Comment by Hashar (talk | contribs)   09:30, 2 March 2011

I am in favour of your position:

- keep feature disabled for 1.17 tarball

- mark the feature (and its related bugs) as blocking 1.18 release

Status & tagging log