r70526 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r70525‎ | r70526 | r70527 >
Date:20:30, 5 August 2010
Author:simetrical
Status:ok (Comments)
Tags:
Comment:
Enable $wgExperimentalHtmlIds by default

This will result in much prettier anchors, which should actually be
intelligible in foreign languages. For instance, for a section named
"שלום", the URL will end in "#שלום" instead of
"#.D7.A9.D7.9C.D7.95.D7.9D". Old links will still work, since the
legacy anchors are still being output too.

This has been enabled on TranslateWiki since January, and there have
been zero complaints. I tested just now in IE6, Firefox 3.6, Firefox
4.0, Chrome dev channel, and Opera 10.60, and all work. I tested Opera
10.50 and IE8 some months ago as well. A test case is at:

http://www.mediawiki.org/wiki/User:Simetrical/Id_test

(A lot of the tests are expected to fail because they already fail
anyway.) Earlier testing indicated that Opera 10.10 wouldn't work
correctly, but that's negligible by now compared to the readability
improvements for foreign languages. Additional testing would be
appreciated, particularly in IE7, IE8, and IE9 in their various
compatibility modes, but I hope this should be good to go by now.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES
——@@ -135,6 +135,9 @@
136136 * (bug 23848) Add {{ARTICLEPATH}} Magic Word.
137137 * JavaScript-based password complexity checker on account creation and
138138 password change.
 139+* The HTML ID's generated for sections are now much prettier when they contain
 140+ punctuation or non-English letters, so a section named "Hello?" will now
 141+ result in a URL ending in "#Hello?" rather than "#Hello.3F".
139142
140143 === Bug fixes in 1.17 ===
141144 * (bug 17560) Half-broken deletion moved image files to deletion archive
Index: trunk/phase3/includes/DefaultSettings.php
——@@ -2256,7 +2256,7 @@
22572257 * and 8, and Opera 10.50, but it fails in Opera 10.10: Unicode IDs don't seem
22582258 * to work as anchors. So not quite ready for general use yet.
22592259 */
2260 -$wgExperimentalHtmlIds = false;
 2260+$wgExperimentalHtmlIds = true;
22612261
22622262 /**
22632263 * Search form behavior for Vector skin only

Follow-up revisions

RevisionCommit summaryAuthorDate
r83061Disable $wgExperimentalHtmlIds again by default...simetrical01:35, 2 March 2011
r83720Backport r83061 "Disable $wgExperimentalHtmlIds again by default"...simetrical21:00, 11 March 2011
r83721Remove HISTORY for r70526...simetrical21:01, 11 March 2011

Comments

#Comment by Simetrical (talk | contribs)   19:56, 12 August 2010

Tested in IE8 and IE8 compatibility mode, so it's probably fine, unless it breaks for some crazy reason in IE9.

#Comment by 😂 (talk | contribs)   18:20, 7 February 2011

I haven't had any issues with this either (using my usual Chrome/Firefox environment).

I haven't tested it nearly as extensively, but the fact that this has been in production use on Translatewiki for a year without complaints speaks a lot. Plus Aryeh tested it again in August :)

Comment above it about "not ready for general use" probably needs changing :)

Status & tagging log