r83720 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83719‎ | r83720 | r83721 >
Date:21:00, 11 March 2011
Author:simetrical
Status:ok
Tags:
Comment:
Backport r83061 "Disable $wgExperimentalHtmlIds again by default"

No RELEASE-NOTES because it's only a regression fix, it was disabled by
default in 1.16. Removed RELEASE-NOTES for r70526. Original commit
message:

See bug 27733, bug 27694, bug 27474. Reverts r70526. Should be
backported to 1.17 (along with removing r70526's RELEASE-NOTES). Can be
ported to WMF as well, but it's kind of trivial to replicate in
LocalSettings.php, so doesn't really have to be.
Modified paths:
  • /branches/REL1_17/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_17/phase3/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/DefaultSettings.php
@@ -2296,11 +2296,11 @@
22972297 * not, use only HTML 4-compatible IDs. This option is for testing -- when the
22982298 * functionality is ready, it will be on by default with no option.
22992299 *
2300 - * Currently this appears to work fine in Chrome 4 and 5, Firefox 3.5 and 3.6, IE6
2301 - * and 8, and Opera 10.50, but it fails in Opera 10.10: Unicode IDs don't seem
2302 - * to work as anchors. So not quite ready for general use yet.
 2300+ * Currently this appears to work fine in all browsers, but it's disabled by
 2301+ * default because it normalizes id's a bit too aggressively, breaking preexisting
 2302+ * content (particularly Cite). See bug 27733, bug 27694, bug 27474.
23032303 */
2304 -$wgExperimentalHtmlIds = true;
 2304+$wgExperimentalHtmlIds = false;
23052305
23062306 /**
23072307 * Abstract list of footer icons for skins in place of old copyrightico and poweredbyico code
Index: branches/REL1_17/phase3/RELEASE-NOTES
@@ -185,9 +185,6 @@
186186 ** When several pages are given the same sort key, they sort by their names
187187 instead of randomly.
188188 * (bug 23848) Add {{ARTICLEPATH}} Magic Word.
189 -* The HTML ID's generated for sections are now much prettier when they contain
190 - punctuation or non-English letters, so a section named "Hello?" will now
191 - result in a URL ending in "#Hello?" rather than "#Hello.3F".
192189 * (bug 8140) Add dedicated CSS classes to Special:Newpages elements
193190 * (bug 11005) Add CSS class to empty pages in Special:Newpages
194191 * The parser cache is now shared amongst users whose different settings aren't

Follow-up revisions

RevisionCommit summaryAuthorDate
r83721Remove HISTORY for r70526...simetrical21:01, 11 March 2011
r85481Revert r68358. Causes bug 27474....platonides22:38, 5 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70526Enable $wgExperimentalHtmlIds by default...simetrical20:30, 5 August 2010
r83061Disable $wgExperimentalHtmlIds again by default...simetrical01:35, 2 March 2011

Status & tagging log