r78990 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78989‎ | r78990 | r78991 >
Date:03:42, 25 December 2010
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
Giving #mw-log-console position 'fixed' instead of 'absolute' (to have it stay on the bottom when scrolling down)
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.log.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.log.js
@@ -35,7 +35,7 @@
3636 if ( !$log.length ) {
3737 $log = $( '<div id="mw-log-console"></div>' )
3838 .css( {
39 - 'position': 'absolute',
 39+ 'position': 'fixed',
4040 'overflow': 'auto',
4141 'z-index': 500,
4242 'bottom': '0px',

Follow-up revisions

RevisionCommit summaryAuthorDate
r839321.17wmf1: MFT r78990, r79844, r81548, r82022, r82193, r83061, r83067, r83583,...catrope17:59, 14 March 2011

Comments

#Comment by Krinkle (talk | contribs)   20:41, 28 February 2011

Tagging for 1.17wmf1 and REL1_17, mw-log-console sucks otherwise on any page longer than 2-3 paragraphs.

Status & tagging log