r82022 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82021‎ | r82022 | r82023 >
Date:18:20, 12 February 2011
Author:raymond
Status:ok (Comments)
Tags:
Comment:
ufirst the username to make sure that http://meta.wikimedia.org/wiki/Special:CentralAuth/raymond works too.
Modified paths:
  • /trunk/extensions/CentralAuth/SpecialCentralAuth.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/SpecialCentralAuth.php
——@@ -10,7 +10,7 @@
1111 function execute( $subpage ) {
1212 global $wgOut;
1313 global $wgExtensionAssetsPath, $wgCentralAuthStyleVersion;
14 - global $wgUser, $wgRequest;
 14+ global $wgUser, $wgRequest, $wgContLang;
1515 $this->setHeaders();
1616
1717 $this->mCanUnmerge = $wgUser->isAllowed( 'centralauth-unmerge' );
——@@ -28,6 +28,8 @@
2929 trim(
3030 str_replace( '_', ' ',
3131 $wgRequest->getText( 'target', $subpage ) ) );
 32+
 33+ $this->mUserName = $wgContLang->ucfirst( $this->mUserName );
3234
3335 $this->mPosted = $wgRequest->wasPosted();
3436 $this->mMethod = $wgRequest->getVal( 'wpMethod' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r839321.17wmf1: MFT r78990, r79844, r81548, r82022, r82193, r83061, r83067, r83583,...catrope17:59, 14 March 2011

Comments

#Comment by Siebrand (talk | contribs)   15:59, 8 March 2011

OK and tagging wmf-deployment.

#Comment by Siebrand (talk | contribs)   16:00, 8 March 2011

Ehr, setting back to new, so the guy (no girls yet, are there?) to merge it can assess quality.

#Comment by Catrope (talk | contribs)   16:00, 8 March 2011

We use the 1.17wmf1 tag for that now.

#Comment by Siebrand (talk | contribs)   16:01, 8 March 2011

Argh, mid-air collision in bugzilla terms. Please fix whatever needs fixing now in this rev's metadata, Roan.

#Comment by Catrope (talk | contribs)   16:02, 8 March 2011

You reset it to new, that's all. Fixed.

Status & tagging log