r82482 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82481‎ | r82482 | r82483 >
Date:20:35, 19 February 2011
Author:hartman
Status:ok (Comments)
Tags:
Comment:
All functions of the importer have $title, origTitle, but processTitle() returned $title, origTitle.
This caused confusion and a misusage of the processTitle() result.

Follow up to r66267.
Fixes bug 27486
Modified paths:
  • /trunk/phase3/includes/Import.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Import.php
——@@ -662,7 +662,7 @@
663663 return false;
664664 }
665665
666 - return array( $origTitle, $title );
 666+ return array( $title, $origTitle );
667667 }
668668 }
669669

Follow-up revisions

RevisionCommit summaryAuthorDate
r825331.17wmf1: MFT r78893, r78897, r78909, r82404, r82408, r82409, r82453, r82456,...catrope20:13, 20 February 2011
r85211MFT: r82297, r82307, r82309, r82312, r82315, r82337, r82391, r82392, r82403, ...demon21:01, 2 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66267Rewrite of XML Dump Processing:...werdna13:28, 12 May 2010

Comments

#Comment by TheDJ (talk | contribs)   20:37, 19 February 2011

that should be 'returned $origTitle, $title' of course.

Status & tagging log