r82387 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82386‎ | r82387 | r82388 >
Date:10:32, 18 February 2011
Author:reedy
Status:ok
Tags:
Comment:
Comment out 2 unused lines in JavaScriptDistiller
Modified paths:
  • /trunk/phase3/includes/libs/JavaScriptDistiller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/libs/JavaScriptDistiller.php
@@ -152,7 +152,7 @@
153153 private $GROUPS = '/\(/';//g
154154 private $SUB_REPLACE = '/\$\d/';
155155 private $INDEXED = '/^\$\d+$/';
156 - private $TRIM = '/([\'"])\1\.(.*)\.\1\1$/';
 156+ //private $TRIM = '/([\'"])\1\.(.*)\.\1\1$/';
157157 private $ESCAPE = '/\\\./';//g
158158 private $QUOTE = '/\'/';
159159 private $DELETED = '/\x01[^\x01]*\x01/';//g
@@ -266,7 +266,7 @@
267267
268268 private function _backReferences($match, $offset) {
269269 $replacement = $this->buffer['replacement'];
270 - $quote = $this->buffer['quote'];
 270+ //$quote = $this->buffer['quote'];
271271 $i = $this->buffer['length'];
272272 while ($i) {
273273 $replacement = str_replace('$'.$i--, $match[$offset + $i], $replacement);

Status & tagging log