r46180 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46179‎ | r46180 | r46181 >
Date:01:43, 25 January 2009
Author:aaron
Status:reverted (Comments)
Tags:
Comment:
Check $row->page_is_redirect directly
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -466,7 +466,7 @@
467467
468468 $page = Title::makeTitle( $row->page_namespace, $row->page_title );
469469 $page->resetArticleId( $row->rev_page ); // use process cache
470 - $link = $sk->makeLinkObj( $page, $page->getPrefixedText(), $page->isRedirect() ? 'redirect=no' : '' );
 470+ $link = $sk->makeLinkObj( $page, $page->getPrefixedText(), $row->page_is_redirect ? 'redirect=no' : '' );
471471 # Mark current revisions
472472 $difftext = $topmarktext = '';
473473 if( $row->rev_id == $row->page_latest ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r46181Revert r46180 and use newFromRow to get page_is_redirect loaded correctlyaaron02:02, 25 January 2009

Comments

#Comment by Aaron Schulz (talk | contribs)   02:02, 25 January 2009

Reverted in r46181

Status & tagging log