r46181 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46180‎ | r46181 | r46182 >
Date:02:02, 25 January 2009
Author:aaron
Status:ok
Tags:
Comment:
Revert r46180 and use newFromRow to get page_is_redirect loaded correctly
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -464,9 +464,9 @@
465465 $sk = $this->getSkin();
466466 $rev = new Revision( $row );
467467
468 - $page = Title::makeTitle( $row->page_namespace, $row->page_title );
 468+ $page = Title::newFromRow( $row );
469469 $page->resetArticleId( $row->rev_page ); // use process cache
470 - $link = $sk->makeLinkObj( $page, $page->getPrefixedText(), $row->page_is_redirect ? 'redirect=no' : '' );
 470+ $link = $sk->makeLinkObj( $page, $page->getPrefixedText(), $page->isRedirect() ? 'redirect=no' : '' );
471471 # Mark current revisions
472472 $difftext = $topmarktext = '';
473473 if( $row->rev_id == $row->page_latest ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r82297Fix the issue where all links on Special:Contributions where marked as stubs ...platonides21:30, 16 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r46180Check $row->page_is_redirect directlyaaron01:43, 25 January 2009

Status & tagging log