r82363 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82362‎ | r82363 | r82364 >
Date:23:16, 17 February 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: MFT r82297, r82312, r82337
Modified paths:
  • /branches/wmf/1.17wmf1/RELEASE-NOTES (modified) (history)
  • /branches/wmf/1.17wmf1/includes/api/ApiQueryPageProps.php (modified) (history)
  • /branches/wmf/1.17wmf1/includes/specials/SpecialContributions.php (modified) (history)
  • /branches/wmf/1.17wmf1/includes/specials/SpecialNewpages.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/includes/api/ApiQueryPageProps.php
@@ -108,7 +108,7 @@
109109 * @return bool True if it fits in the result
110110 */
111111 private function addPageProps( $result, $page, $props ) {
112 - $fit = $result->addValue( array( 'query', 'pages' ), $page, $props );
 112+ $fit = $result->addValue( array( 'query', 'pages', $page ), 'pageprops', $props );
113113
114114 if ( !$fit ) {
115115 $this->setContinueEnumParameter( 'continue', $page );
Property changes on: branches/wmf/1.17wmf1/includes/api/ApiQueryPageProps.php
___________________________________________________________________
Modified: svn:mergeinfo
116116 Merged /trunk/phase3/includes/api/ApiQueryPageProps.php:r82297,82312,82337
Index: branches/wmf/1.17wmf1/includes/specials/SpecialNewpages.php
@@ -366,7 +366,7 @@
367367
368368 $feed->outHeader();
369369 if( $pager->getNumRows() > 0 ) {
370 - foreach ( $pager->mResult->fetchObject() as $row ) {
 370+ foreach ( $pager->mResult as $row ) {
371371 $feed->outItem( $this->feedItem( $row ) );
372372 }
373373 }
Index: branches/wmf/1.17wmf1/includes/specials/SpecialContributions.php
@@ -616,7 +616,6 @@
617617 $classes = array();
618618
619619 $page = Title::newFromRow( $row );
620 - $page->resetArticleId( $row->rev_page ); // use process cache
621620 $link = $sk->link(
622621 $page,
623622 htmlspecialchars( $page->getPrefixedText() ),
Index: branches/wmf/1.17wmf1/RELEASE-NOTES
@@ -499,6 +499,8 @@
500500 * (bug 24650) Fix API to work with categorylinks changes
501501 * action=parse now correctly returns an error for nonexistent pages
502502 * (bug 27201) Special:WhatLinksHere output no longer contains duplicate IDs
 503+* (bug 27479) API error when using both prop=pageprops and
 504+ prop=info&inprop=displaytitle
503505
504506 * (bug 22738) Allow filtering by action type on query=logevent.
505507 * (bug 22764) uselang parameter for action=parse.
Property changes on: branches/wmf/1.17wmf1/RELEASE-NOTES
___________________________________________________________________
Modified: svn:mergeinfo
506508 Merged /trunk/phase3/RELEASE-NOTES:r82297,82312,82337

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82297Fix the issue where all links on Special:Contributions where marked as stubs ...platonides21:30, 16 February 2011
r82312* (bug 27479) API error when using both prop=pageprops and prop=info&inprop=d...reedy23:38, 16 February 2011
r82337Fix broken Special:Newpages Atom feed.vasilievvv16:29, 17 February 2011

Status & tagging log