r82201 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82200‎ | r82201 | r82202 >
Date:22:22, 15 February 2011
Author:platonides
Status:deferred (Comments)
Tags:
Comment:
Segmentation fault in in gc_zval_possible_root() from wmerrors_write_full_backtrace() line zval_ptr_dtor(&exception);
Follow up r82158.
Modified paths:
  • /trunk/php/wmerrors/wmerrors.c (modified) (history)

Diff [purge]

Index: trunk/php/wmerrors/wmerrors.c
——@@ -312,7 +312,7 @@
313313 if (!exception_class) {
314314 return;
315315 }
316 - ALLOC_ZVAL(exception);
 316+ MAKE_STD_ZVAL(exception);
317317 object_init_ex(exception, exception_class);
318318
319319 /* Call Exception::getTraceAsString() */

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82158* Use Exception::getTraceAsString() to get the backtrace, instead of debug_pr...tstarling04:56, 15 February 2011

Comments

#Comment by Tim Starling (talk | contribs)   22:29, 15 February 2011

Removing 1.17wmf1 tag since you can't backport something in this path, and backporting wouldn't do much good anyway.

#Comment by Platonides (talk | contribs)   23:47, 15 February 2011

I tagged it 1.17wmf1 to mean that the servers where the extension got installed should get the update.

Status & tagging log