r82038 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82037‎ | r82038 | r82039 >
Date:22:46, 12 February 2011
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
Follow-up r81731 CR comments. Calling wfExpandUrl() on remote base path.
Modified paths:
  • /trunk/phase3/includes/resourceloader/ResourceLoaderFileModule.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/resourceloader/ResourceLoaderFileModule.php
——@@ -150,6 +150,7 @@
151151 global $wgExtensionAssetsPath;
152152 $this->remoteBasePath = $wgExtensionAssetsPath . '/' . $options['remoteExtPath'];
153153 }
 154+ $this->remoteBasePath = wfExpandUrl( $this->remoteBasePath );
154155
155156 foreach ( $options as $member => $option ) {
156157 switch ( $member ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r82039Follow-up r82038. Calling wfExpandUrl() on remote base path *AFTER* is has be...krinkle23:20, 12 February 2011
r820411.17wmf1: MFT r82038, r82039catrope23:24, 12 February 2011
r85151MFT: r82000, r82004, r82020, r82025, r82038, r82039, r82048, r82070, r82081, ...demon20:39, 1 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81731Remove $wgServer prepending from remote JS/CSS paths. It's not needed and bre...catrope12:34, 8 February 2011

Comments

#Comment by Krinkle (talk | contribs)   22:48, 12 February 2011

Fixes bugzilla:27321, should be merged to 1.17 and especially 1.17wmf1 asap to allow debugging.

Status & tagging log