r82020 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82019‎ | r82020 | r82021 >
Date:17:15, 12 February 2011
Author:ialex
Status:ok (Comments)
Tags:
Comment:
* Fix hook name
* Update paths in findhooks script
Modified paths:
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/maintenance/findhooks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/findhooks.php
@@ -63,14 +63,15 @@
6464 $IP . '/includes/installer/',
6565 $IP . '/includes/parser/',
6666 $IP . '/includes/resourceloader/',
 67+ $IP . '/includes/revisiondelete/',
6768 $IP . '/includes/search/',
6869 $IP . '/includes/specials/',
6970 $IP . '/includes/upload/',
7071 $IP . '/languages/',
7172 $IP . '/maintenance/',
72 - $IP . '/maintenance/tests/',
73 - $IP . '/maintenance/tests/parser/',
74 - $IP . '/maintenance/tests/phpunit/suites/',
 73+ $IP . '/tests/',
 74+ $IP . '/tests/parser/',
 75+ $IP . '/tests/phpunit/suites/',
7576 $IP . '/skins/',
7677 );
7778
Index: trunk/phase3/docs/hooks.txt
@@ -1124,7 +1124,7 @@
11251125 'MakeGlobalVariablesScript': called right before Skin::makeVariablesScript
11261126 is executed. Ideally, this hook should only be used to add variables that
11271127 depend on the current page/request; static configuration should be added
1128 -through ResourceLoaderConfigVars instead.
 1128+through ResourceLoaderGetConfigVars instead.
11291129 &$vars: variable (or multiple variables) to be added into the output
11301130 of Skin::makeVariablesScript
11311131
@@ -1388,7 +1388,7 @@
13891389 'RecentChange_save': called at the end of RecentChange::save()
13901390 $recentChange: RecentChange object
13911391
1392 -'ResourceLoaderConfigVars': called at the end of
 1392+'ResourceLoaderGetConfigVars': called at the end of
13931393 ResourceLoaderStartUpModule::getConfig(). Use this to export static
13941394 configuration variables to JavaScript. Things that depend on the current
13951395 page/request state must be added through MakeGlobalVariablesScript instead.

Follow-up revisions

RevisionCommit summaryAuthorDate
r85151MFT: r82000, r82004, r82020, r82025, r82038, r82039, r82048, r82070, r82081, ...demon20:39, 1 April 2011

Comments

#Comment by Hashar (talk | contribs)   21:23, 12 February 2011

Should the hooks.txt part get merged in 1.17 ?

#Comment by 😂 (talk | contribs)   21:24, 12 February 2011

Yes, since the hooks are part of 1.17 :)

Status & tagging log