r87498 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87497‎ | r87498 | r87499 >
Date:15:04, 5 May 2011
Author:valhallasw
Status:ok (Comments)
Tags:
Comment:
Fixes ForeignDBRepo SQL server connection. Fixes bug #28836.
Modified paths:
  • /trunk/phase3/includes/filerepo/ForeignDBRepo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/ForeignDBRepo.php
@@ -37,7 +37,7 @@
3838 if ( !isset( $this->dbConn ) ) {
3939 $this->dbConn = DatabaseBase::newFromType( $this->dbType,
4040 array(
41 - 'server' => $this->dbServer,
 41+ 'host' => $this->dbServer,
4242 'user' => $this->dbUser,
4343 'password' => $this->dbPassword,
4444 'dbname' => $this->dbName,

Follow-up revisions

RevisionCommit summaryAuthorDate
r87544Fix for r80864, host not server. Like r87498demon14:57, 6 May 2011
r96557MFT r80167, r81689, r87498, r89253reedy12:38, 8 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80864Followup to r79848 (and really, make it useful...)...demon16:31, 24 January 2011

Comments

#Comment by Catrope (talk | contribs)   18:19, 7 June 2011

Untagging 1.17. Fixes a regression introduced after the 1.17 branch point

#Comment by Catrope (talk | contribs)   16:43, 7 September 2011

... but the rev was merged to 1.17 anyway. WHOOPS. Re-tagging 1.17

Status & tagging log