r81600 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81599‎ | r81600 | r81601 >
Date:18:25, 6 February 2011
Author:vyznev
Status:ok
Tags:
Comment:
(bug 27201) fix duplicate IDs in recursive whatlinkshere output
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialWhatlinkshere.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialWhatlinkshere.php
@@ -239,7 +239,7 @@
240240 $wgOut->addHTML( $prevnext );
241241 }
242242
243 - $wgOut->addHTML( $this->listStart() );
 243+ $wgOut->addHTML( $this->listStart( $level ) );
244244 foreach ( $rows as $row ) {
245245 $nt = Title::makeTitle( $row->page_namespace, $row->page_title );
246246
@@ -259,8 +259,8 @@
260260 }
261261 }
262262
263 - protected function listStart() {
264 - return Xml::openElement( 'ul', array ( 'id' => 'mw-whatlinkshere-list' ) );
 263+ protected function listStart( $level ) {
 264+ return Xml::openElement( 'ul', ( $level ? array() : array( 'id' => 'mw-whatlinkshere-list' ) ) );
265265 }
266266
267267 protected function listItem( $row, $nt, $notClose = false ) {
Index: trunk/phase3/RELEASE-NOTES
@@ -145,6 +145,7 @@
146146 * (bug 24650) Fix API to work with categorylinks changes
147147 * Expose list of skins in meta=siteinfo
148148 * (bug 26548) Add iiurlparam param to query=imageinfo and query=stashimageinfo
 149+* (bug 27201) Special:WhatLinksHere output no longer contains duplicate IDs
149150
150151 === Languages updated in 1.18 ===
151152

Follow-up revisions

RevisionCommit summaryAuthorDate
r81617Followup r81600, put bug fix incorrect BUG FIX section, rather than the API s...reedy00:00, 7 February 2011
r816541.17: MFT r78372, r79324, r80841, r81430, r81488, r81496, r81554, r81561, r81...catrope22:28, 7 February 2011

Status & tagging log