r81496 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81495‎ | r81496 | r81497 >
Date:00:20, 4 February 2011
Author:happy-melon
Status:ok (Comments)
Tags:
Comment:
Revert r70270; per CR comments.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialWhatlinkshere.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialWhatlinkshere.php
@@ -264,13 +264,11 @@
265265 }
266266
267267 protected function listItem( $row, $nt, $notClose = false ) {
268 - global $wgLang;
269 -
270268 # local message cache
271269 static $msgcache = null;
272270 if ( $msgcache === null ) {
273271 static $msgs = array( 'isredirect', 'istemplate', 'semicolon-separator',
274 - 'whatlinkshere-links', 'isimage', 'hist' );
 272+ 'whatlinkshere-links', 'isimage' );
275273 $msgcache = array();
276274 foreach ( $msgs as $msg ) {
277275 $msgcache[$msg] = wfMsgExt( $msg, array( 'escapenoentities' ) );
@@ -305,10 +303,8 @@
306304 }
307305
308306 # Space for utilities links, with a what-links-here link provided
309 - $tools = array();
310 - $tools[] = $this->wlhLink( $nt, $msgcache['whatlinkshere-links'] );
311 - $tools[] = $this->skin->linkKnown( $nt, $msgcache['hist'], array(), array( 'action' => 'history' ) );
312 - $wlh = Xml::wrapClass( '(' . $wgLang->pipeList( $tools ) . ')', 'mw-whatlinkshere-tools' );
 307+ $wlhLink = $this->wlhLink( $nt, $msgcache['whatlinkshere-links'] );
 308+ $wlh = Xml::wrapClass( "($wlhLink)", 'mw-whatlinkshere-tools' );
313309
314310 return $notClose ?
315311 Xml::openElement( 'li' ) . "$link $propsText $wlh\n" :

Follow-up revisions

RevisionCommit summaryAuthorDate
r816541.17: MFT r78372, r79324, r80841, r81430, r81488, r81496, r81554, r81561, r81...catrope22:28, 7 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70270* (bug 24563) Entries on Special:WhatLinksHere now have a link to their historyialex09:20, 1 August 2010

Comments

#Comment by Happy-melon (talk | contribs)   00:23, 4 February 2011

Note that while the RELEASE-NOTES entry is no longer present on trunk, it will be in the 1.17 branch and will need to be removed there.

Status & tagging log