r81430 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r81429‎ | r81430 | r81431 >
Date:22:59, 2 February 2011
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Fixed bug #26829 by increasing the specificity of the CSS hack used to get IE6 working so that it doesn't also affect IE7.
Modified paths:
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/screen.css
——@@ -1138,7 +1138,6 @@
11391139 #ca-watch.icon {
11401140 margin-right:1px;
11411141 }
1142 -/* OVERRIDDEN BY COMPLIANT BROWSERS */
11431142 #ca-unwatch.icon a,
11441143 #ca-watch.icon a {
11451144 margin: 0;
——@@ -1148,17 +1147,14 @@
11491148 width: 26px;
11501149 /* This hides the text but shows the background image */
11511150 padding-top: 3.1em;
1152 - margin-top: -0.8em;
 1151+ margin-top: 0;
 1152+ /* Only applied in IE6 */
 1153+ margin-top: -0.8em !ie;
11531154 height: 0;
11541155 overflow: hidden;
11551156 /* @embed */
11561157 background-image: url(images/watch-icons.png);
11571158 }
1158 -/* IGNORED BY IE6 */
1159 -html > body #ca-unwatch.icon a,
1160 -html > body #ca-watch.icon a {
1161 - margin-top: 0;
1162 -}
11631159 #ca-unwatch.icon a {
11641160 background-position: -43px 60%;
11651161 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r816541.17: MFT r78372, r79324, r80841, r81430, r81488, r81496, r81554, r81561, r81...catrope22:28, 7 February 2011

Comments

#Comment by Krinkle (talk | contribs)   01:51, 3 February 2011

So before this commit the default was margin-top: -0.8em;, which (excepet for IE6 and older) was overridden with margin-top: 0; (the wanted value for most browsers).

After this commit the default is margin-top: 0; and, margin-top: -0.8em !ie (using the !ie css-hack), overrides it for IE6.

Result should indeed be the same, however according go the linked page !ie also applies to IE7. We should verify this to be sure.

#Comment by Trevor Parscal (WMF) (talk | contribs)   18:08, 3 February 2011

Yes, my commit comment was wrong actually - sorry - as you say, this DOES apply this to IE7, where it did not before, and that's a good thing. I have tested it in IE6, 7 and 8. I welcome confirmations from other people.

Status & tagging log