r80841 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r80840‎ | r80841 | r80842 >
Date:01:00, 24 January 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
(bug 26895) in /include/db/LoadBalancer.php function "closeConnecton" should be called "closeConnection"

Seemingly no callers in extensions OR phase3 (weird...), searching for "closeConnecton" or the correctly spelt "closeConnection"

The back-compat typo thing probably wants removing.. Seems to have been as such since it was added in r32578...
Modified paths:
  • /trunk/phase3/includes/db/LoadBalancer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/LoadBalancer.php
——@@ -761,11 +761,20 @@
762762 }
763763
764764 /**
 765+ * Deprecated function, typo in function name
 766+ */
 767+ function closeConnecton( $conn ) {
 768+ $this->closeConnection( $conn );
 769+ }
 770+
 771+ /**
765772 * Close a connection
766773 * Using this function makes sure the LoadBalancer knows the connection is closed.
767774 * If you use $conn->close() directly, the load balancer won't update its state.
 775+ * @param $conn
 776+ * @return void
768777 */
769 - function closeConnecton( $conn ) {
 778+ function closeConnection( $conn ) {
770779 $done = false;
771780 foreach ( $this->mConns as $i1 => $conns2 ) {
772781 foreach ( $conns2 as $i2 => $conns3 ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r816541.17: MFT r78372, r79324, r80841, r81430, r81488, r81496, r81554, r81561, r81...catrope22:28, 7 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r32578* Introduced LBFactory -- an abstract class for configuring database load bal...tstarling09:48, 30 March 2008

Comments

#Comment by Hashar (talk | contribs)   17:14, 24 January 2011

Since it never worked, is it needed? :) Should it get backported to 1.16 and 1.16wmf4?

#Comment by Reedy (talk | contribs)   17:17, 24 January 2011

1.17 maybe, 1.16wmf4 no point, 1.16 seems useless also

Status & tagging log