r81488 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81487‎ | r81488 | r81489 >
Date:21:27, 3 February 2011
Author:catrope
Status:ok
Tags:
Comment:
Followup r69094: check that $t is a Title before it's used as one
Modified paths:
  • /trunk/extensions/Collection/Collection.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.php
@@ -368,7 +368,9 @@
369369 if ( $t->isRedirect() ) {
370370 $a = new Article( $t, 0 );
371371 $t = $a->followRedirect();
372 - $title = $t->getPrefixedText();
 372+ if ( $t instanceof Title ) {
 373+ $title = $t->getPrefixedText();
 374+ }
373375 }
374376 if ( CollectionSession::findArticle( $title ) == - 1 ) {
375377 $result['action'] = 'add';

Follow-up revisions

RevisionCommit summaryAuthorDate
r816541.17: MFT r78372, r79324, r80841, r81430, r81488, r81496, r81554, r81561, r81...catrope22:28, 7 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69094follow redirects in popup codejojo13:45, 6 July 2010

Status & tagging log