r81497 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81496‎ | r81497 | r81498 >
Date:00:21, 4 February 2011
Author:mah
Status:ok
Tags:
Comment:
re r81495 — you know, I've completely forgotten why I wanted to return a status object. Fix that and not the busted status message.
Modified paths:
  • /trunk/phase3/includes/installer/PostgresInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/PostgresInstaller.php
@@ -138,10 +138,10 @@
139139 );
140140
141141 if( !$rights || ( $rights != 1 && $rights != 3 ) ) {
142 - $status = Status::newFatal("can't create");
 142+ return false;
143143 }
144144
145 - return $status;
 145+ return true;
146146 }
147147
148148 public function getSettingsForm() {
@@ -164,7 +164,7 @@
165165 // Validate the create checkbox
166166 $create = true;
167167 $canCreate = $this->canCreateAccounts();
168 - if ( !$canCreate->isOK() ) {
 168+ if ( $canCreate ) {
169169 $this->setVar( '_CreateDBAccount', false );
170170 $create = false;
171171 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81495* make canCreateAccounts() return Status Objects instead of boolean...mah00:15, 4 February 2011

Status & tagging log