r79926 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79925‎ | r79926 | r79927 >
Date:04:47, 10 January 2011
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
traversal indention. Follow-up r79924
Modified paths:
  • /trunk/phase3/resources/mediawiki.special/mediawiki.special.preferences.js (modified) (history)
  • /trunk/phase3/resources/mediawiki.util/mediawiki.util.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.util/mediawiki.util.js
@@ -455,7 +455,7 @@
456456 "|" / "}" /
457457 "~"
458458 */
459 - var rfc5322_atext = "a-z0-9!#$%&'*+-/=?^_`{|}�~",
 459+ var rfc5322_atext = "a-z0-9!#$%&'*+-/=?^_`{|}�~",
460460
461461 /**
462462 * Next define the RFC 1034 'ldh-str'
Index: trunk/phase3/resources/mediawiki.special/mediawiki.special.preferences.js
@@ -7,37 +7,38 @@
88 .addClass( 'jsprefs' )
99 .before( $( '<ul id="preftoc"></ul>' ) )
1010 .children( 'fieldset' )
11 - .hide()
12 - .addClass( 'prefsection' )
13 - .children( 'legend' )
14 - .addClass( 'mainLegend' )
15 - .each( function( i ) {
16 - $(this).parent().attr( 'id', 'prefsection-' + i );
17 - if ( i === 0 ) {
18 - $(this).parent().show();
19 - }
20 - $( '#preftoc' ).append(
21 - $( '<li></li>' )
22 - .addClass( i === 0 ? 'selected' : null )
23 - .append(
24 - $( '<a></a>')
25 - .text( $(this).text() )
26 - .attr( 'href', '#prefsection-' + i )
27 - .mousedown( function( e ) {
28 - $(this).parent().parent().find( 'li' ).removeClass( 'selected' );
29 - $(this).parent().addClass( 'selected' );
30 - e.preventDefault();
31 - return false;
32 - } )
33 - .click( function( e ) {
34 - $( '#preferences > fieldset' ).hide();
35 - $( '#prefsection-' + i ).show();
36 - e.preventDefault();
37 - return false;
38 - } )
39 - )
40 - );
41 - } );
 11+ .hide()
 12+ .addClass( 'prefsection' )
 13+ .children( 'legend' )
 14+ .addClass( 'mainLegend' )
 15+ .each( function( i ) {
 16+ $(this).parent().attr( 'id', 'prefsection-' + i );
 17+ if ( i === 0 ) {
 18+ $(this).parent().show();
 19+ }
 20+ $( '#preftoc' ).append(
 21+ $( '<li></li>' )
 22+ .addClass( i === 0 ? 'selected' : null )
 23+ .append(
 24+ $( '<a></a>')
 25+ .text( $(this).text() )
 26+ .attr( 'href', '#prefsection-' + i )
 27+ .mousedown( function( e ) {
 28+ $(this).parent().parent().find( 'li' ).removeClass( 'selected' );
 29+ $(this).parent().addClass( 'selected' );
 30+ e.preventDefault();
 31+ return false;
 32+ } )
 33+ .click( function( e ) {
 34+ $( '#preferences > fieldset' ).hide();
 35+ $( '#prefsection-' + i ).show();
 36+ e.preventDefault();
 37+ return false;
 38+ } )
 39+ )
 40+ );
 41+ }
 42+ );
4243
4344 /**
4445 * Given an email validity status (true, false, null) update the label CSS class

Follow-up revisions

RevisionCommit summaryAuthorDate
r809751.17: MFT r79856, r79877, r79878, r79885, r79924, r79926, r79952catrope18:07, 25 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79924* Consistent single quotes...krinkle04:40, 10 January 2011

Comments

#Comment by Hashar (talk | contribs)   20:04, 10 January 2011

Encoding issue in trunk/phase3/resources/mediawiki.util/mediawiki.util.js was fixed with r79952.

#Comment by Krinkle (talk | contribs)   20:20, 10 January 2011

Thanks.

Status & tagging log