r79925 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79924‎ | r79925 | r79926 >
Date:04:44, 10 January 2011
Author:reedy
Status:ok
Tags:
Comment:
Documentation addition/tweaks
Modified paths:
  • /trunk/phase3/includes/Xml.php (modified) (history)
  • /trunk/phase3/includes/resourceloader/ResourceLoaderModule.php (modified) (history)
  • /trunk/phase3/includes/resourceloader/ResourceLoaderUserOptionsModule.php (modified) (history)
  • /trunk/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Xml.php
@@ -620,7 +620,7 @@
621621 * Create a call to a JavaScript function. The supplied arguments will be
622622 * encoded using Xml::encodeJsVar().
623623 *
624 - * @param $name The name of the function to call, or a JavaScript expression
 624+ * @param $name String The name of the function to call, or a JavaScript expression
625625 * which evaluates to a function object which is called.
626626 * @param $args Array of arguments to pass to the function.
627627 * @since 1.17
Index: trunk/phase3/includes/resourceloader/ResourceLoaderUserOptionsModule.php
@@ -109,6 +109,10 @@
110110 return array();
111111 }
112112
 113+ /**
 114+ * @param $context ResourceLoaderContext
 115+ * @return bool
 116+ */
113117 public function getFlip( $context ) {
114118 global $wgContLang;
115119
Index: trunk/phase3/includes/resourceloader/ResourceLoaderModule.php
@@ -58,6 +58,7 @@
5959
6060 /**
6161 * Get whether CSS for this module should be flipped
 62+ * @param $context ResourceLoaderContext
6263 */
6364 public function getFlip( $context ) {
6465 return $context->getDirection() === 'rtl';
Index: trunk/phase3/languages/Language.php
@@ -132,6 +132,8 @@
133133
134134 /**
135135 * Get a cached language object for a given language code
 136+ * @param $code String
 137+ * @return Language
136138 */
137139 static function factory( $code ) {
138140 if ( !isset( self::$mLangObjCache[$code] ) ) {
@@ -146,6 +148,8 @@
147149
148150 /**
149151 * Create a language object for a given language code
 152+ * @param $code String
 153+ * @return Language
150154 */
151155 protected static function newFromCode( $code ) {
152156 global $IP;

Status & tagging log