r79927 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79926‎ | r79927 | r79928 >
Date:05:02, 10 January 2011
Author:krinkle
Status:ok
Tags:
Comment:
Adding comma's at end of arrays where this hasn't been done already for consistency
Modified paths:
  • /trunk/phase3/resources/Resources.php (modified) (history)
  • /trunk/phase3/resources/mediawiki.util/mediawiki.util.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.util/mediawiki.util.js
@@ -1,19 +1,19 @@
2 -/*
 2+/**
33 * Utilities
44 */
55
6 -(function ($, mw) {
 6+(function($, mw) {
77
88 mw.util = {
99
1010 /* Initialisation */
1111 'initialised' : false,
12 - 'init' : function () {
 12+ 'init' : function() {
1313 if ( this.initialised === false ) {
1414 this.initialised = true;
1515
1616 // Any initialisation after the DOM is ready
17 - $(function () {
 17+ $(function() {
1818
1919 // Shortcut to client profile return
2020 var profile = $.client.profile();
@@ -374,12 +374,12 @@
375375 /**
376376 * Add a little box at the top of the screen to inform the user of
377377 * something, replacing any previous message.
 378+ * Calling with no arguments, with an empty string or null will hide the message
378379 *
379 - * @param message mixed The DOM-element or HTML-string to be put inside the message box]
380 - * Calling with no arguments, with an empty string or null will hide the message
381 - * @param className string Used in adding a class; should be different for each
382 - * call to allow CSS/JS to hide different boxes. null = no class used.
383 - * @return Boolean True on success, false on failure
 380+ * @param message mixed The DOM-element or HTML-string to be put inside the message box.
 381+ * @param className string Used in adding a class; should be different for each call
 382+ * to allow CSS/JS to hide different boxes. null = no class used.
 383+ * @return boolean True on success, false on failure
384384 */
385385 'jsMessage' : function( message, className ) {
386386
@@ -423,7 +423,7 @@
424424 * according to HTML5 specification. Please note the specification
425425 * does not validate a domain with one character.
426426 *
427 - * FIXME: should be moved to a JavaScript validation module.
 427+ * FIXME: should be moved to or replaced by a JavaScript validation module.
428428 */
429429 'validateEmail' : function( mailtxt ) {
430430 if( mailtxt === '' ) {
@@ -475,7 +475,7 @@
476476 // User part which is liberal :p
477477 '[' + rfc5322_atext + '\\.' + ']' + '+'
478478 +
479 - // "at"
 479+ // 'at'
480480 '@'
481481 +
482482 // Domain first part
Index: trunk/phase3/resources/Resources.php
@@ -12,14 +12,14 @@
1313 /* Skins */
1414
1515 'skins.vector' => array(
16 - 'styles' => array( 'skins/vector/screen.css' => array( 'media' => 'screen' ) )
 16+ 'styles' => array( 'skins/vector/screen.css' => array( 'media' => 'screen' ) ),
1717 ),
1818 'skins.monobook' => array(
1919 'styles' => array(
2020 'skins/monobook/main.css' => array( 'media' => 'screen' ),
2121 // Honor $wgHandheldStyle. This is kind of evil
22 - //$GLOBALS['wgHandheldStyle'] => array( 'media' => 'handheld' )
23 - )
 22+ //$GLOBALS['wgHandheldStyle'] => array( 'media' => 'handheld' ),
 23+ ),
2424 ),
2525
2626 /* jQuery */
@@ -32,48 +32,48 @@
3333 /* jQuery Plugins */
3434
3535 'jquery.async' => array(
36 - 'scripts' => 'resources/jquery/jquery.async.js'
 36+ 'scripts' => 'resources/jquery/jquery.async.js',
3737 ),
3838 'jquery.autoEllipsis' => array(
3939 'scripts' => 'resources/jquery/jquery.autoEllipsis.js',
4040 'dependencies' => 'jquery.highlightText',
4141 ),
4242 'jquery.checkboxShiftClick' => array(
43 - 'scripts' => 'resources/jquery/jquery.checkboxShiftClick.js'
 43+ 'scripts' => 'resources/jquery/jquery.checkboxShiftClick.js',
4444 ),
4545 'jquery.client' => array(
4646 'scripts' => 'resources/jquery/jquery.client.js',
4747 ),
4848 'jquery.collapsibleTabs' => array(
49 - 'scripts' => 'resources/jquery/jquery.collapsibleTabs.js'
 49+ 'scripts' => 'resources/jquery/jquery.collapsibleTabs.js',
5050 ),
5151 'jquery.colorUtil' => array(
52 - 'scripts' => 'resources/jquery/jquery.colorUtil.js'
 52+ 'scripts' => 'resources/jquery/jquery.colorUtil.js',
5353 ),
5454 'jquery.color' => array(
5555 'scripts' => 'resources/jquery/jquery.color.js',
56 - 'dependencies' => 'jquery.colorUtil'
 56+ 'dependencies' => 'jquery.colorUtil',
5757 ),
5858 'jquery.cookie' => array(
59 - 'scripts' => 'resources/jquery/jquery.cookie.js'
 59+ 'scripts' => 'resources/jquery/jquery.cookie.js',
6060 ),
6161 'jquery.delayedBind' => array(
62 - 'scripts' => 'resources/jquery/jquery.delayedBind.js'
 62+ 'scripts' => 'resources/jquery/jquery.delayedBind.js',
6363 ),
6464 'jquery.expandableField' => array(
65 - 'scripts' => 'resources/jquery/jquery.expandableField.js'
 65+ 'scripts' => 'resources/jquery/jquery.expandableField.js',
6666 ),
6767 'jquery.highlightText' => array(
68 - 'scripts' => 'resources/jquery/jquery.highlightText.js'
 68+ 'scripts' => 'resources/jquery/jquery.highlightText.js',
6969 ),
7070 'jquery.hoverIntent' => array(
71 - 'scripts' => 'resources/jquery/jquery.hoverIntent.js'
 71+ 'scripts' => 'resources/jquery/jquery.hoverIntent.js',
7272 ),
7373 'jquery.placeholder' => array(
74 - 'scripts' => 'resources/jquery/jquery.placeholder.js'
 74+ 'scripts' => 'resources/jquery/jquery.placeholder.js',
7575 ),
7676 'jquery.localize' => array(
77 - 'scripts' => 'resources/jquery/jquery.localize.js'
 77+ 'scripts' => 'resources/jquery/jquery.localize.js',
7878 ),
7979 'jquery.makeCollapsible' => array(
8080 'scripts' => 'resources/jquery/jquery.makeCollapsible.js',
@@ -85,10 +85,10 @@
8686 'styles' => 'resources/jquery/jquery.suggestions.css',
8787 ),
8888 'jquery.tabIndex' => array(
89 - 'scripts' => 'resources/jquery/jquery.tabIndex.js'
 89+ 'scripts' => 'resources/jquery/jquery.tabIndex.js',
9090 ),
9191 'jquery.textSelection' => array(
92 - 'scripts' => 'resources/jquery/jquery.textSelection.js'
 92+ 'scripts' => 'resources/jquery/jquery.textSelection.js',
9393 ),
9494 'jquery.tipsy' => array(
9595 'scripts' => 'resources/jquery.tipsy/jquery.tipsy.js',
@@ -130,7 +130,7 @@
131131 'jquery.ui.droppable' => array(
132132 'scripts' => 'resources/jquery.ui/jquery.ui.droppable.js',
133133 'dependencies' => array(
134 - 'jquery.ui.core', 'jquery.ui.mouse', 'jquery.ui.widget', 'jquery.ui.draggable'
 134+ 'jquery.ui.core', 'jquery.ui.mouse', 'jquery.ui.widget', 'jquery.ui.draggable',
135135 ),
136136 ),
137137 'jquery.ui.resizable' => array(
@@ -237,7 +237,7 @@
238238 'vi' => 'resources/jquery.ui/i18n/jquery.ui.datepicker-vi.js',
239239 'zh-cn' => 'resources/jquery.ui/i18n/jquery.ui.datepicker-zh-CN.js',
240240 'zh-hk' => 'resources/jquery.ui/i18n/jquery.ui.datepicker-zh-HK.js',
241 - 'zh-tw' => 'resources/jquery.ui/i18n/jquery.ui.datepicker-zh-TW.js'
 241+ 'zh-tw' => 'resources/jquery.ui/i18n/jquery.ui.datepicker-zh-TW.js',
242242 ),
243243 ),
244244 'jquery.ui.dialog' => array(
@@ -430,8 +430,7 @@
431431 'mediawiki.legacy.ajax' => array(
432432 'scripts' => 'skins/common/ajax.js',
433433 'messages' => array(
434 - 'watch', 'unwatch', 'watching', 'unwatching', 'tooltip-ca-watch',
435 - 'tooltip-ca-unwatch'
 434+ 'watch', 'unwatch', 'watching', 'unwatching', 'tooltip-ca-watch', 'tooltip-ca-unwatch',
436435 ),
437436 'dependencies' => 'mediawiki.legacy.wikibits',
438437 ),

Status & tagging log