r79856 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79855‎ | r79856 | r79857 >
Date:03:11, 8 January 2011
Author:robla
Status:resolved (Comments)
Tags:
Comment:
Bug 26563: Add bytes changed per revision for stub and full article dumps
Modified paths:
  • /trunk/phase3/includes/Export.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Export.php
@@ -354,7 +354,7 @@
355355 * @return string
356356 */
357357 function schemaVersion() {
358 - return "0.4";
 358+ return "0.5";
359359 }
360360
361361 /**
@@ -511,12 +511,12 @@
512512 // Raw text from the database may have invalid chars
513513 $text = strval( Revision::getRevisionText( $row ) );
514514 $out .= " " . Xml::elementClean( 'text',
515 - array( 'xml:space' => 'preserve' ),
 515+ array( 'xml:space' => 'preserve', 'bytes' => $row->rev_len ),
516516 strval( $text ) ) . "\n";
517517 } else {
518518 // Stub output
519519 $out .= " " . Xml::element( 'text',
520 - array( 'id' => $row->rev_text_id ),
 520+ array( 'id' => $row->rev_text_id, 'bytes' => $row->rev_len ),
521521 "" ) . "\n";
522522 }
523523

Follow-up revisions

RevisionCommit summaryAuthorDate
r79877Creating export-0.5.xsd as part of followup to r79856robla02:27, 9 January 2011
r79878Followup to r79856: s/0.4/0.5/ and added "bytes" attribute to "text" elementrobla02:38, 9 January 2011
r809751.17: MFT r79856, r79877, r79878, r79885, r79924, r79926, r79952catrope18:07, 25 January 2011

Comments

#Comment by MaxSem (talk | contribs)   08:54, 8 January 2011

Needs an accompanying XSD in docs/.

#Comment by RobLa-WMF (talk | contribs)   20:42, 8 January 2011

I'll work on this today. Any particular validator tool I should test with?

#Comment by RobLa-WMF (talk | contribs)   02:43, 9 January 2011

New schema version checked in, along with fixes to make the 0.4 schema actually validate our current dumps.

#Comment by Brion VIBBER (talk | contribs)   23:03, 11 July 2011

New schema version file isn't available at the expected URL: http://www.mediawiki.org/xml/export-0.5.xsd

#Comment by Brion VIBBER (talk | contribs)   23:08, 11 July 2011

Added to shell bugs: bug 29819.

#Comment by Reedy (talk | contribs)   00:23, 12 July 2011

It's there now

Status & tagging log