r79952 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79951‎ | r79952 | r79953 >
Date:19:55, 10 January 2011
Author:hashar
Status:ok
Tags:
Comment:
Fix RFC 5322 'atext'

An additional character was introducted in the RFC 5322 atext fragment.
Spotted with r79924 which send the file as latin1 encoding.
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)
  • /trunk/phase3/resources/mediawiki.util/mediawiki.util.js (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -652,7 +652,7 @@
653653 if( !wfRunHooks( 'isValidEmailAddr', array( $addr, &$result ) ) ) {
654654 return $result;
655655 }
656 - $rfc5322_atext = "a-z0-9!#$%&'*+-\/=?^_`{|}—~" ;
 656+ $rfc5322_atext = "a-z0-9!#$%&'*+-\/=?^_`{|}~" ;
657657 $rfc1034_ldh_str = "a-z0-9-" ;
658658
659659 $HTML5_email_regexp = "/
Index: trunk/phase3/resources/mediawiki.util/mediawiki.util.js
@@ -455,7 +455,7 @@
456456 "|" / "}" /
457457 "~"
458458 */
459 - var rfc5322_atext = "a-z0-9!#$%&'*+-/=?^_`{|}�~",
 459+ var rfc5322_atext = "a-z0-9!#$%&'*+-/=?^_`{|}~",
460460
461461 /**
462462 * Next define the RFC 1034 'ldh-str'
@@ -496,4 +496,4 @@
497497
498498 mw.util.init();
499499
500 -})(jQuery, mediaWiki);
\ No newline at end of file
 500+})(jQuery, mediaWiki);

Follow-up revisions

RevisionCommit summaryAuthorDate
r809751.17: MFT r79856, r79877, r79878, r79885, r79924, r79926, r79952catrope18:07, 25 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79924* Consistent single quotes...krinkle04:40, 10 January 2011

Status & tagging log