r65774 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65773‎ | r65774 | r65775 >
Date:01:59, 2 May 2010
Author:simetrical
Status:resolved (Comments)
Tags:
Comment:
Improve IE6 version check to avoid false positives

Bug 23171. Not added to RELEASE-NOTES because I'll backport to 1.16.
Modified paths:
  • /trunk/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/wikibits.js
@@ -25,8 +25,14 @@
2626 var opera7_bugs = is_opera_seven && !is_opera_95;
2727 var opera95_bugs = /opera\/(9\.5)/.test( clientPC );
2828 }
29 -// Start at 4 to minimize the chance of breaking on IE10 :)
30 -var ie6_bugs = /msie [4-6]/.test( clientPC );
 29+// As recommended by <http://msdn.microsoft.com/en-us/library/ms537509.aspx>,
 30+// avoiding false positives from moronic extensions that append to the IE UA
 31+// string (bug 23171)
 32+var ie6_bugs = false;
 33+if ( /MSIE ([0-9]{1,}[\.0-9]{0,})/.exec( clientPC ) != null
 34+&& parseFloat( RegExp.$1 ) <= 6.0 ) {
 35+ ie6_bugs = true;
 36+}
3137
3238 // Global external objects used by this script.
3339 /*extern ta, stylepath, skin */

Follow-up revisions

RevisionCommit summaryAuthorDate
r65775Backport r65774 "Improve IE6 version check to avoid false positives"...simetrical02:00, 2 May 2010
r66861MFT r65774: Improve IE6 version check to avoid false positiveststarling01:10, 25 May 2010
r73978Fix IEFixes.js loading again...simetrical20:05, 29 September 2010
r73979Backport r73978 "Fix IEFixes.js loading again"...simetrical20:13, 29 September 2010

Comments

#Comment by Hashar (talk | contribs)   17:51, 29 September 2010

Marking this revision as fixme since it is referenced in https://bugzilla.wikimedia.org/show_bug.cgi?id=25167

#Comment by Simetrical (talk | contribs)   20:05, 29 September 2010

Fixed in r73978, so I'm marking resolved.

Status & tagging log