r66861 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66860‎ | r66861 | r66862 >
Date:01:10, 25 May 2010
Author:tstarling
Status:deferred
Tags:
Comment:
MFT r65774: Improve IE6 version check to avoid false positives
Modified paths:
  • /branches/wmf/1.16wmf4/skins/common (modified) (history)
  • /branches/wmf/1.16wmf4/skins/common/jquery.js (modified) (history)
  • /branches/wmf/1.16wmf4/skins/common/jquery.min.js (modified) (history)
  • /branches/wmf/1.16wmf4/skins/common/preview.js (modified) (history)
  • /branches/wmf/1.16wmf4/skins/common/wikibits.js (modified) (history)

Diff [purge]

Property changes on: branches/wmf/1.16wmf4/skins/common/jquery.js
___________________________________________________________________
Name: svn:mergeinfo
11 - /trunk/phase3/skins/common/jquery.js:63549,63764,63897-63901,65015
22 + /trunk/phase3/skins/common/jquery.js:63549,63764,63897-63901,65015,65774
Property changes on: branches/wmf/1.16wmf4/skins/common/jquery.min.js
___________________________________________________________________
Name: svn:mergeinfo
33 - /trunk/phase3/skins/common/jquery.min.js:63549,63764,63897-63901,65015
44 + /trunk/phase3/skins/common/jquery.min.js:63549,63764,63897-63901,65015,65774
Property changes on: branches/wmf/1.16wmf4/skins/common/preview.js
___________________________________________________________________
Name: svn:mergeinfo
55 - /branches/wmf-deployment/skins/common/preview.js:60970
/trunk/phase3/skins/common/preview.js:63545-63546,63549,63643,63764,63897-63901,65015,65384,65388
66 + /branches/wmf-deployment/skins/common/preview.js:60970
/trunk/phase3/skins/common/preview.js:63545-63546,63549,63643,63764,63897-63901,65015,65384,65388,65774
Index: branches/wmf/1.16wmf4/skins/common/wikibits.js
@@ -25,8 +25,14 @@
2626 var opera7_bugs = is_opera_seven && !is_opera_95;
2727 var opera95_bugs = /opera\/(9\.5)/.test( clientPC );
2828 }
29 -// Start at 4 to minimize the chance of breaking on IE10 :)
30 -var ie6_bugs = /msie [4-6]/.test( clientPC );
 29+// As recommended by <http://msdn.microsoft.com/en-us/library/ms537509.aspx>,
 30+// avoiding false positives from moronic extensions that append to the IE UA
 31+// string (bug 23171)
 32+var ie6_bugs = false;
 33+if ( /MSIE ([0-9]{1,}[\.0-9]{0,})/.exec( clientPC ) != null
 34+&& parseFloat( RegExp.$1 ) <= 6.0 ) {
 35+ ie6_bugs = true;
 36+}
3137
3238 // Global external objects used by this script.
3339 /*extern ta, stylepath, skin */
Property changes on: branches/wmf/1.16wmf4/skins/common
___________________________________________________________________
Name: svn:mergeinfo
3440 + /branches/wmf-deployment/skins/common:60970
/trunk/phase3/skins/common:63545-63546,63549,63643,63764,63897-63901,65015,65387,65391,65555,65590,65774

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65774Improve IE6 version check to avoid false positives...simetrical01:59, 2 May 2010

Status & tagging log