r65775 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65774‎ | r65775 | r65776 >
Date:02:00, 2 May 2010
Author:simetrical
Status:ok
Tags:
Comment:
Backport r65774 "Improve IE6 version check to avoid false positives"

Backported as a regression from 1.15 due to r60994. Original commit
message:

Bug 23171. Not added to RELEASE-NOTES because I'll backport to 1.16.
Modified paths:
  • /branches/REL1_16/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_16/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: branches/REL1_16/phase3/skins/common/wikibits.js
@@ -25,8 +25,14 @@
2626 var opera7_bugs = is_opera_seven && !is_opera_95;
2727 var opera95_bugs = /opera\/(9\.5)/.test( clientPC );
2828 }
29 -// Start at 4 to minimize the chance of breaking on IE10 :)
30 -var ie6_bugs = /msie [4-6]/.test( clientPC );
 29+// As recommended by <http://msdn.microsoft.com/en-us/library/ms537509.aspx>,
 30+// avoiding false positives from moronic extensions that append to the IE UA
 31+// string (bug 23171)
 32+var ie6_bugs = false;
 33+if ( /MSIE ([0-9]{1,}[\.0-9]{0,})/.exec( clientPC ) != null
 34+&& parseFloat( RegExp.$1 ) <= 6.0 ) {
 35+ ie6_bugs = true;
 36+}
3137
3238 // Global external objects used by this script.
3339 /*extern ta, stylepath, skin */
Index: branches/REL1_16/phase3/RELEASE-NOTES
@@ -63,6 +63,7 @@
6464 check.
6565 * (bug 23167) Check the watch checkbox by default if the watchcreations
6666 preference is set.
 67+* (bug 23171) Improve IE6 version check to avoid false positives.
6768
6869 === Changes since 1.16 beta 1 ===
6970

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r60994Merge IEFixes.js into wikibits.js...simetrical23:36, 12 January 2010
r65774Improve IE6 version check to avoid false positives...simetrical01:59, 2 May 2010

Status & tagging log