r73978 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r73977‎ | r73978 | r73979 >
Date:20:05, 29 September 2010
Author:simetrical
Status:ok
Tags:
Comment:
Fix IEFixes.js loading again

Bug 25167. The fix in r65774 was wrong -- apparently I didn't test well
enough. I've tested the new fix by loading IE6 and requesting a page
from my wiki without it, verifying with Wireshark that no HTTP request
was sent for IEFixes.js, and then repeating with the fix applied to
verify it works.

Will backport to 1.16, like r65774, since this is still a regression
from 1.15. Note that only IE6 and less were ever affected, and things
seem to be mostly usable without the fixes file, so I don't think this
is of enormous importance.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/wikibits.js
——@@ -41,7 +41,7 @@
4242 // avoiding false positives from moronic extensions that append to the IE UA
4343 // string (bug 23171)
4444 window.ie6_bugs = false;
45 -if ( /MSIE ([0-9]{1,}[\.0-9]{0,})/.exec( clientPC ) != null
 45+if ( /msie ([0-9]{1,}[\.0-9]{0,})/.exec( clientPC ) != null
4646 && parseFloat( RegExp.$1 ) <= 6.0 ) {
4747 ie6_bugs = true;
4848 }
——@@ -1101,4 +1101,4 @@
11021102
11031103 // jQuery alias
11041104
1105 -window.$j = jQuery;
\ No newline at end of file
 1105+window.$j = jQuery;
Index: trunk/phase3/RELEASE-NOTES
——@@ -340,6 +340,7 @@
341341 * SQLite system table names are now never prefixed.
342342 * (bug 25292) SkinSubPageSubtitle hook now passes the Skin object as second
343343 parameter
 344+* (bug 25167) Correctly load JS fixes for IE6 (fixing a regression in 1.16)
344345
345346 === API changes in 1.17 ===
346347 * (bug 22738) Allow filtering by action type on query=logevent.

Follow-up revisions

RevisionCommit summaryAuthorDate
r73979Backport r73978 "Fix IEFixes.js loading again"...simetrical20:13, 29 September 2010
r741981.16wmf4: MFT r73978catrope11:19, 3 October 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65774Improve IE6 version check to avoid false positives...simetrical01:59, 2 May 2010

Status & tagging log