r73979 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r73978‎ | r73979 | r73980 >
Date:20:13, 29 September 2010
Author:simetrical
Status:deferred
Tags:
Comment:
Backport r73978 "Fix IEFixes.js loading again"

Original commit message:

Bug 25167. The fix in r65774 was wrong -- apparently I didn't test well
enough. I've tested the new fix by loading IE6 and requesting a page
from my wiki without it, verifying with Wireshark that no HTTP request
was sent for IEFixes.js, and then repeating with the fix applied to
verify it works.

Will backport to 1.16, like r65774, since this is still a regression
from 1.15. Note that only IE6 and less were ever affected, and things
seem to be mostly usable without the fixes file, so I don't think this
is of enormous importance.
Modified paths:
  • /branches/REL1_16/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_16/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: branches/REL1_16/phase3/skins/common/wikibits.js
——@@ -29,7 +29,7 @@
3030 // avoiding false positives from moronic extensions that append to the IE UA
3131 // string (bug 23171)
3232 var ie6_bugs = false;
33 -if ( /MSIE ([0-9]{1,}[\.0-9]{0,})/.exec( clientPC ) != null
 33+if ( /msie ([0-9]{1,}[\.0-9]{0,})/.exec( clientPC ) != null
3434 && parseFloat( RegExp.$1 ) <= 6.0 ) {
3535 ie6_bugs = true;
3636 }
Index: branches/REL1_16/phase3/RELEASE-NOTES
——@@ -50,6 +50,7 @@
5151 * (bug 24166) API error when using rvprop=tags
5252 * For wikis setup in French language, Special:Téléchargement works again
5353 as an alias for Special:Upload
 54+* (bug 25167) Correctly load JS fixes for IE6 (fixing a regression in 1.16.0)
5455
5556 == Changes since 1.16 beta 3 ==
5657

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65774Improve IE6 version check to avoid false positives...simetrical01:59, 2 May 2010
r73978Fix IEFixes.js loading again...simetrical20:05, 29 September 2010

Status & tagging log