r41724 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r41723‎ | r41724 | r41725 >
Date:04:22, 6 October 2008
Author:tstarling
Status:old (Comments)
Tags:
Comment:
Remove apparently unnecessary <span> around images, causes invalid XHTML when the image contains block-level elements, as in ImageMap and OggHandler.
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
——@@ -803,7 +803,7 @@
804804 'img-class' => isset( $fp['border'] ) ? 'thumbborder' : false ) );
805805 }
806806 if ( '' != $fp['align'] ) {
807 - $s = "<div class=\"float{$fp['align']}\"><span>{$s}</span></div>";
 807+ $s = "<div class=\"float{$fp['align']}\">{$s}</div>";
808808 }
809809 return str_replace("\n", ' ',$prefix.$s.$postfix);
810810 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r41785Cleanup for r41724: parser test cases altered by removal of unneeded <span> i...brion23:30, 6 October 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   23:27, 6 October 2008

Breaks parser tests... have been previously removed, and restored due to this. :)

was added by Gabriel Wicke in r2953 "to allow better css styling", but doesn't appear to have been really used. Doesn't seem any clear benefit to it, so let's kill it and fix the tests. :)

#Comment by Brion VIBBER (talk | contribs)   23:31, 6 October 2008

4 parser test cases fixed in r41785

Status & tagging log