r41723 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41722‎ | r41723 | r41724 >
Date:03:49, 6 October 2008
Author:aaron
Status:old (Comments)
Tags:
Comment:
Remove some redundant "starting from" message cruft (bug 3327)
Modified paths:
  • /trunk/phase3/includes/specials/SpecialRecentchanges.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRecentchanges.php
@@ -593,18 +593,6 @@
594594
595595 $options = $nondefaults + $defaults;
596596
597 - if( $options['from'] )
598 - $note = wfMsgExt( 'rcnotefrom', array( 'parseinline' ),
599 - $wgLang->formatNum( $options['limit'] ),
600 - $wgLang->timeanddate( $options['from'], true ) );
601 - else
602 - $note = wfMsgExt( 'rcnote', array( 'parseinline' ),
603 - $wgLang->formatNum( $options['limit'] ),
604 - $wgLang->formatNum( $options['days'] ),
605 - $wgLang->timeAndDate( wfTimestampNow(), true ),
606 - $wgLang->date( wfTimestampNow(), true ),
607 - $wgLang->time( wfTimestampNow(), true ) );
608 -
609597 # Sort data for display and make sure it's unique after we've added user data.
610598 $wgRCLinkLimits[] = $options['limit'];
611599 $wgRCLinkDays[] = $options['days'];
@@ -659,6 +647,6 @@
660648 $rclinks = wfMsgExt( 'rclinks', array( 'parseinline', 'replaceafter' ),
661649 $cl, $dl, $hl );
662650 $rclistfrom = wfMsgExt( 'rclistfrom', array( 'parseinline', 'replaceafter' ), $tl );
663 - return "$note<br />$rclinks<br />$rclistfrom";
 651+ return "$rclinks<br />$rclistfrom";
664652 }
665653 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r41811Follow up on r41723. 'rcnotefrom' is no longer in use.siebrand16:33, 7 October 2008
r42768Revert r41723 and follow-up r41811: rcnotefrom had one non-redundant field an...aaron15:35, 29 October 2008
r42769Redo r41723: still show rcnotefrom as needed, but not rcnote. Add rclegend me...aaron15:47, 29 October 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r34983Improve UI for Special:Recentchanges and Special:Recentchangeslinked....dantman16:08, 17 May 2008

Comments

#Comment by Siebrand (talk | contribs)   16:36, 7 October 2008

'rcnotefrom' messages removed in r41811.

Status & tagging log