r2953 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r2952‎ | r2953 | r2954 >
Date:01:50, 4 April 2004
Author:gabrielwicke
Status:old
Tags:
Comment:
* aditional span / div inside floated image-div to allow better css styling
* small xhtml tweaks
* DaVinci and Mono temporarily disabled
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -19,9 +19,10 @@
2020 }
2121 if( $wgUsePHPTal ) {
2222 #$wgValidSkinNames[] = "PHPTal";
23 - $wgValidSkinNames['davinci'] = "DaVinci";
24 - $wgValidSkinNames['mono'] = "Mono";
 23+ #$wgValidSkinNames['davinci'] = "DaVinci";
 24+ #$wgValidSkinNames['mono'] = "Mono";
2525 $wgValidSkinNames['monobook'] = "MonoBook";
 26+ #$wgValidSkinNames['monobookminimal'] = "MonoBookMinimal";
2627 }
2728
2829 include_once( "RecentChange.php" );
@@ -1550,7 +1551,7 @@
15511552 " <img border=\"0\" src=\"{$url}\" alt=\"{$alt}\" />\n </a>";
15521553 }
15531554 if ( "" != $align ) {
1554 - $s = "<div class=\"float{$align}\">{$s}\n</div>";
 1555+ $s = "<div class=\"float{$align}\"><span>{$s}\n</span></div>";
15551556 }
15561557 return $prefix.$s.$postfix;
15571558 }
@@ -1688,7 +1689,7 @@
16891690 $magnifyalign = $wgLang->isRTL() ? "left" : "right";
16901691 $textalign = $wgLang->isRTL() ? " style=\"text-align:right\"" : "";
16911692
1692 - $s = "<div class=\"thumbnail-{$align}\" style=\"width:{$boxwidth}px;\">";
 1693+ $s = "<div class=\"thumbnail-{$align}\" style=\"width:{$boxwidth}px;\"><div>";
16931694 if ( $thumbUrl == "" ) {
16941695 $s .= str_replace( "$1", $name, wfMsg("missingimage") );
16951696 } else {
@@ -1699,7 +1700,7 @@
17001701 ' <img border="0" src="'.$wgUploadPath.'/magnify-clip.png" ' .
17011702 'width="26" height="24" align="'.$magnifyalign.'" alt="'.$more.'" /> </a>'."\n";
17021703 }
1703 - $s .= ' <p'.$textalign.'>'.$label."</p>\n</div>";
 1704+ $s .= ' <p'.$textalign.'>'.$label."</p>\n</div></div>";
17041705 return $s;
17051706 }
17061707
@@ -2276,11 +2277,11 @@
22772278 # try min-width & co when somebody gets a chance
22782279 $hideline = " <script type='text/javascript'>showTocToggle(\"" . addslashes( wfMsg("showtoc") ) . "\",\"" . addslashes( wfMsg("hidetoc") ) . "\")</script>";
22792280 return
2280 - "<p><table border=\"0\" id=\"toc\"><tr><td align=\"center\">\n".
 2281+ "<table border=\"0\" id=\"toc\"><tr><td align=\"center\">\n".
22812282 "<b>".wfMsg("toc")."</b>" .
22822283 $hideline .
22832284 "</td></tr><tr id='tocinside'><td>\n".
2284 - $toc."</td></tr></table><P>\n";
 2285+ $toc."</td></tr></table>\n";
22852286 }
22862287
22872288 # These two do not check for permissions: check $wgTitle->userCanEdit before calling them

Follow-up revisions

RevisionCommit summaryAuthorDate
r41785Cleanup for r41724: parser test cases altered by removal of unneeded <span> i...brion23:30, 6 October 2008

Status & tagging log