r41725 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41724‎ | r41725 | r41726 >
Date:04:24, 6 October 2008
Author:tstarling
Status:old
Tags:
Comment:
Fix for bug 8718. Cooperate with image centering by specifying widths on divs so that the margin:auto trick can work.
Modified paths:
  • /trunk/extensions/ImageMap/ImageMap_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ImageMap/ImageMap_body.php
@@ -289,11 +289,12 @@
290290 } else {
291291 $marginTop = -20;
292292 }
293 - $div->setAttribute( 'style', "height: {$thumbHeight}px" );
 293+ $div->setAttribute( 'style', "height: {$thumbHeight}px; width: {$thumbWidth}px; " );
294294 $descWrapper = $div->appendChild( new DOMElement( 'div' ) );
295295 $descWrapper->setAttribute( 'style',
296296 "margin-left: {$marginLeft}px; " .
297 - "margin-top: {$marginTop}px; "
 297+ "margin-top: {$marginTop}px; " .
 298+ "text-align: left;"
298299 );
299300
300301 $descAnchor = $descWrapper->appendChild( new DOMElement( 'a' ) );

Status & tagging log