r41785 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r41784‎ | r41785 | r41786 >
Date:23:30, 6 October 2008
Author:brion
Status:old
Tags:
Comment:
Cleanup for r41724: parser test cases altered by removal of unneeded <span> in floating thumb.

The stray <span> was added by Gabriel Wicke in r2953 "to allow better css styling", but doesn't appear to have been really used. Doesn't seem any clear benefit to it, and it causes problems with fancy media types like OggHandler, so let's kill it and fix the tests. :)
Modified paths:
  • /trunk/phase3/maintenance/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.txt
——@@ -3081,7 +3081,7 @@
30823082 !! input
30833083 [[Image:foobar.jpg|right]]
30843084 !! result
3085 -<div class="floatright"><span><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a></span></div>
 3085+<div class="floatright"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a></div>
30863086
30873087 !! end
30883088
——@@ -3090,7 +3090,7 @@
30913091 !! input
30923092 [[Image:foobar.jpg|right|Caption text]]
30933093 !! result
3094 -<div class="floatright"><span><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Caption text"><img alt="Caption text" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a></span></div>
 3094+<div class="floatright"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Caption text"><img alt="Caption text" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a></div>
30953095
30963096 !! end
30973097
——@@ -6189,7 +6189,7 @@
61906190 !! input
61916191 [[Image:foobar.jpg|centre]]
61926192 !! result
6193 -<div class="center"><div class="floatnone"><span><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a></span></div></div>
 6193+<div class="center"><div class="floatnone"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a></div></div>
61946194
61956195 !!end
61966196
——@@ -6198,7 +6198,7 @@
61996199 !! input
62006200 [[Image:foobar.jpg|none]]
62016201 !! result
6202 -<div class="floatnone"><span><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a></span></div>
 6202+<div class="floatnone"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a></div>
62036203
62046204 !!end
62056205

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r2953* aditional span / div inside floated image-div to allow better css styling...gabrielwicke01:50, 4 April 2004
r41724Remove apparently unnecessary <span> around images, causes invalid XHTML when...tstarling04:22, 6 October 2008

Status & tagging log