r112709 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r112708‎ | r112709 | r112710 >
Date:20:00, 29 February 2012
Author:wikinaut
Status:reverted (Comments)
Tags:gerritmigration 
Comment:
function name typo correction. Version number update
Modified paths:
  • /trunk/extensions/RSS/RELEASE-NOTES (modified) (history)
  • /trunk/extensions/RSS/RSS.php (modified) (history)
  • /trunk/extensions/RSS/RSSHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RSS/RSSHooks.php
——@@ -64,7 +64,7 @@
6565 }
6666
6767 if ( !Http::isValidURI( $input ) ) {
68 - return RSSutils::RSSError( 'rss-invalid-url', htmlspecialchars( $input ) );
 68+ return RSSUtils::RSSError( 'rss-invalid-url', htmlspecialchars( $input ) );
6969 }
7070 if ( $wgRSSCacheCompare ) {
7171 $timeout = $wgRSSCacheCompare;
Index: trunk/extensions/RSS/RELEASE-NOTES
——@@ -11,6 +11,10 @@
1212 (otherwise using the defaults - PHP will abort the entire program when your
1313 memory usage gets too high)
1414
 15+
 16+=== Version 2.11 2012-02-29 ===
 17+* function name typo correction
 18+
1519 === Version 2.10 2012-02-27 ===
1620 * final solution of bug 30028 "Error parsing XML for RSS" - improve and harden
1721 Extension:RSS when parsing differently flavoured RSS feeds and ATOM feeds
Index: trunk/extensions/RSS/RSS.php
——@@ -4,7 +4,7 @@
55 *
66 * @file
77 * @ingroup Extensions
8 - * @version 2.10
 8+ * @version 2.11
99 * @author mutante, Daniel Kinzler, Rdb, Mafs, Thomas Gries, Alxndr, Chris Reigrut, K001
1010 * @author Kellan Elliott-McCrea <kellan@protest.net> -- author of MagpieRSS
1111 * @author Jeroen De Dauw
——@@ -14,7 +14,7 @@
1515 * @link http://www.mediawiki.org/wiki/Extension:RSS Documentation
1616 */
1717
18 -define( "EXTENSION_RSS_VERSION", "2.10 20120227" );
 18+define( "EXTENSION_RSS_VERSION", "2.11 20120229" );
1919
2020 if ( !defined( 'MEDIAWIKI' ) ) {
2121 die( "This is not a valid entry point.\n" );
——@@ -94,4 +94,4 @@
9595 // limit the number of characters in the item description
9696 // or set to false for unlimited length.
9797 // $wgRSSItemMaxLength = false;
98 -$wgRSSItemMaxLength = 200;
 98+$wgRSSItemMaxLength = false;

Follow-up revisions

RevisionCommit summaryAuthorDate
r113297fix for bug34763 'RSS feed items (HTML) are not rendered as HTML but htmlesca...wikinaut21:06, 7 March 2012
r114390Revert r111347, r111348, r111350, r111351, r111515, r111816, r112243, r112251......catrope18:40, 21 March 2012

Comments

#Comment by 😂 (talk | contribs)   04:59, 21 March 2012

I'm not sure a capitalization fix requires a new version ;-)

In any case--you also changed a default setting, what was the rationale for that?

#Comment by Wikinaut (talk | contribs)   06:48, 21 March 2012

Rationale: to deactivate this value for the time being - extension allows for HTML characters, and a limitation would then probably break HTML tags.

This is commented in follow-up https://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/RSS/RSS.php?revision=113297&view=markup

94 // limit the number of characters in the item description 95 // or set to false for unlimited length. 96 // THIS IS CURRENTLY NOT WORKING (bug 30377) 97 $wgRSSItemMaxLength = false;

Status & tagging log